New issue
Advanced search Search tips

Issue 917182 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Network process is not notified of memory pressure changes

Project Member Reported by cduvall@chromium.org, Dec 20

Issue description

The network process was not getting memory pressure notifications, which may have caused a memory increase on Android.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e7516428e43ec2a9dcfdcc6ae53458c7f6af075

commit 6e7516428e43ec2a9dcfdcc6ae53458c7f6af075
Author: Clark DuVall <cduvall@chromium.org>
Date: Thu Dec 27 23:42:06 2018

Notify network process of memory pressure changes

The network process was not receiving memory pressure notifications,
which prevented //net code from clearing caches and doing other things
to reduce memory usage. This was a possible cause of a memory increase
on Android with network service enabled.

Bug:  917182 
Change-Id: I9c8a5d697bde10e49d49cbeb9d6ef85a93d3fd19
Reviewed-on: https://chromium-review.googlesource.com/c/1388036
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619091}
[modify] https://crrev.com/6e7516428e43ec2a9dcfdcc6ae53458c7f6af075/content/browser/network_service_browsertest.cc
[modify] https://crrev.com/6e7516428e43ec2a9dcfdcc6ae53458c7f6af075/content/browser/network_service_client.cc
[modify] https://crrev.com/6e7516428e43ec2a9dcfdcc6ae53458c7f6af075/content/browser/network_service_client.h
[modify] https://crrev.com/6e7516428e43ec2a9dcfdcc6ae53458c7f6af075/content/public/test/network_service_test_helper.cc
[modify] https://crrev.com/6e7516428e43ec2a9dcfdcc6ae53458c7f6af075/services/network/network_service.cc
[modify] https://crrev.com/6e7516428e43ec2a9dcfdcc6ae53458c7f6af075/services/network/network_service.h
[modify] https://crrev.com/6e7516428e43ec2a9dcfdcc6ae53458c7f6af075/services/network/public/cpp/network_param.typemap
[modify] https://crrev.com/6e7516428e43ec2a9dcfdcc6ae53458c7f6af075/services/network/public/cpp/network_param_mojom_traits.cc
[modify] https://crrev.com/6e7516428e43ec2a9dcfdcc6ae53458c7f6af075/services/network/public/cpp/network_param_mojom_traits.h
[modify] https://crrev.com/6e7516428e43ec2a9dcfdcc6ae53458c7f6af075/services/network/public/mojom/network_param.mojom
[modify] https://crrev.com/6e7516428e43ec2a9dcfdcc6ae53458c7f6af075/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/6e7516428e43ec2a9dcfdcc6ae53458c7f6af075/services/network/public/mojom/network_service_test.mojom

Labels: Proj-Servicification-Beta M-72 Merge-Request-72
Requesting merge to M72 for change in comment #1. This is gated by the network service flag and fixes a memory regression in network service.
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 7

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Is the change looking good in canary so far?
Yep, this has been on canary over a week and looks good.
Labels: -Merge-Review-72 Merge-Approved-72
Approving merge to M72 branch 3626 based on comments #2 and #5. 
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 7

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78b2f8e2f3ce6c3bf2b364299a35555883b05989

commit 78b2f8e2f3ce6c3bf2b364299a35555883b05989
Author: Clark DuVall <cduvall@chromium.org>
Date: Mon Jan 07 18:06:43 2019

Notify network process of memory pressure changes

The network process was not receiving memory pressure notifications,
which prevented //net code from clearing caches and doing other things
to reduce memory usage. This was a possible cause of a memory increase
on Android with network service enabled.

Bug:  917182 
Change-Id: I9c8a5d697bde10e49d49cbeb9d6ef85a93d3fd19
Reviewed-on: https://chromium-review.googlesource.com/c/1388036
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#619091}(cherry picked from commit 6e7516428e43ec2a9dcfdcc6ae53458c7f6af075)
Reviewed-on: https://chromium-review.googlesource.com/c/1398305
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#588}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/78b2f8e2f3ce6c3bf2b364299a35555883b05989/content/browser/network_service_browsertest.cc
[modify] https://crrev.com/78b2f8e2f3ce6c3bf2b364299a35555883b05989/content/browser/network_service_client.cc
[modify] https://crrev.com/78b2f8e2f3ce6c3bf2b364299a35555883b05989/content/browser/network_service_client.h
[modify] https://crrev.com/78b2f8e2f3ce6c3bf2b364299a35555883b05989/content/public/test/network_service_test_helper.cc
[modify] https://crrev.com/78b2f8e2f3ce6c3bf2b364299a35555883b05989/services/network/network_service.cc
[modify] https://crrev.com/78b2f8e2f3ce6c3bf2b364299a35555883b05989/services/network/network_service.h
[modify] https://crrev.com/78b2f8e2f3ce6c3bf2b364299a35555883b05989/services/network/public/cpp/network_param.typemap
[modify] https://crrev.com/78b2f8e2f3ce6c3bf2b364299a35555883b05989/services/network/public/cpp/network_param_mojom_traits.cc
[modify] https://crrev.com/78b2f8e2f3ce6c3bf2b364299a35555883b05989/services/network/public/cpp/network_param_mojom_traits.h
[modify] https://crrev.com/78b2f8e2f3ce6c3bf2b364299a35555883b05989/services/network/public/mojom/network_param.mojom
[modify] https://crrev.com/78b2f8e2f3ce6c3bf2b364299a35555883b05989/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/78b2f8e2f3ce6c3bf2b364299a35555883b05989/services/network/public/mojom/network_service_test.mojom

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/78b2f8e2f3ce6c3bf2b364299a35555883b05989

Commit: 78b2f8e2f3ce6c3bf2b364299a35555883b05989
Author: cduvall@chromium.org
Commiter: cduvall@chromium.org
Date: 2019-01-07 18:06:43 +0000 UTC

Notify network process of memory pressure changes

The network process was not receiving memory pressure notifications,
which prevented //net code from clearing caches and doing other things
to reduce memory usage. This was a possible cause of a memory increase
on Android with network service enabled.

Bug:  917182 
Change-Id: I9c8a5d697bde10e49d49cbeb9d6ef85a93d3fd19
Reviewed-on: https://chromium-review.googlesource.com/c/1388036
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#619091}(cherry picked from commit 6e7516428e43ec2a9dcfdcc6ae53458c7f6af075)
Reviewed-on: https://chromium-review.googlesource.com/c/1398305
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#588}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fd3f29634ab12559f97a16f3db2f4ca8394ead9

commit 6fd3f29634ab12559f97a16f3db2f4ca8394ead9
Author: Clark DuVall <cduvall@chromium.org>
Date: Tue Jan 08 19:31:13 2019

Move //base mojo types out of services/network

Follow up to http://crrev.com/c/1388036, this moves //base typemaps into
//mojo/public/cpp/base instead of living in services/network.

Bug:  917182 
Change-Id: Ib306295b143923163c0ee3f77ab1586795a68966
Reviewed-on: https://chromium-review.googlesource.com/c/1399290
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620835}
[add] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/mojo/public/cpp/base/application_state.typemap
[add] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/mojo/public/cpp/base/application_state_mojom_traits.cc
[add] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/mojo/public/cpp/base/application_state_mojom_traits.h
[add] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/mojo/public/cpp/base/memory_pressure_level.typemap
[add] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/mojo/public/cpp/base/memory_pressure_level_mojom_traits.cc
[add] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/mojo/public/cpp/base/memory_pressure_level_mojom_traits.h
[modify] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/mojo/public/cpp/base/typemaps.gni
[modify] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/mojo/public/mojom/base/BUILD.gn
[add] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/mojo/public/mojom/base/application_state.mojom
[add] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/mojo/public/mojom/base/memory_pressure_level.mojom
[modify] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/services/network/public/cpp/network_param.typemap
[delete] https://crrev.com/05008108d5faff24ad2d7c2ce2edf8fb4fc9e588/services/network/public/cpp/network_param_android.typemap
[modify] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/services/network/public/cpp/network_param_mojom_traits.cc
[modify] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/services/network/public/cpp/network_param_mojom_traits.h
[modify] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/services/network/public/cpp/typemaps.gni
[modify] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/services/network/public/mojom/network_param.mojom
[modify] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/6fd3f29634ab12559f97a16f3db2f4ca8394ead9/services/network/public/mojom/network_service_test.mojom

Is CL listed at #10 need a merge to M72 as well?
No, that one isn't necessary, it's just code cleanup.

Sign in to add a comment