New issue
Advanced search Search tips

Issue 917166 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Launcher-Broken


Sign in to add a comment

Answer card should have transparent background

Project Member Reported by xiy...@chromium.org, Dec 20

Issue description

It is using default white. As a result, we see strange gray on the right edge, which is the select/hover color partially shown.

See attached screenshot.
 
answer_card_white_opaque_background.png
58.1 KB View Download
https://chromium-review.googlesource.com/c/chromium/src/+/1387986

Attached screenshot with the CL and it changes with selection (via keyboard).
answer_card_transparent_bg.png
57.9 KB View Download
This should be a duplicate of  Issue 914887  which I have targeted for M72 (assuming a server side fix). 

Xiyuan, do you think your proposed fix is mergeable to M72? If so, I would like to change the target to M72.
Think we should be able to merge to M72.
Cc: manucornet@chromium.org
 Issue 914887  has been merged into this issue.
Labels: -M-73 M-72
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5ebe94b7ee85d5dbbcb82c945352b53401a5330

commit b5ebe94b7ee85d5dbbcb82c945352b53401a5330
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Fri Dec 21 19:24:04 2018

app_list: Answer card use transparent background

- Support background color when creating navigable contents;
- Answer card use transparent for its background color;

Bug:  917166 
Change-Id: Iea7b3449c6bed0eb7735f6b51ecee369f705220a
Reviewed-on: https://chromium-review.googlesource.com/c/1387986
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618571}
[modify] https://crrev.com/b5ebe94b7ee85d5dbbcb82c945352b53401a5330/ash/app_list/views/search_result_answer_card_view.cc
[modify] https://crrev.com/b5ebe94b7ee85d5dbbcb82c945352b53401a5330/content/browser/content_service_delegate_impl.cc
[modify] https://crrev.com/b5ebe94b7ee85d5dbbcb82c945352b53401a5330/services/content/public/mojom/navigable_contents_factory.mojom

Labels: Merge-Request-72
Project Member

Comment 8 by sheriffbot@chromium.org, Dec 22

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-72 Merge-Approved-72
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 26

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc4f3f8b5160908dfc547c1d9ecf89ab44d81ba1

commit fc4f3f8b5160908dfc547c1d9ecf89ab44d81ba1
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Wed Dec 26 19:43:17 2018

Merge M72 "app_list: Answer card use transparent background"

> - Support background color when creating navigable contents;
> - Answer card use transparent for its background color;
>
> Bug:  917166 
> Change-Id: Iea7b3449c6bed0eb7735f6b51ecee369f705220a
> Reviewed-on: https://chromium-review.googlesource.com/c/1387986
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618571}
> (cherry picked from commit b5ebe94b7ee85d5dbbcb82c945352b53401a5330)

Change-Id: If151b88fd7ea8690a94bd4dfe0d86e73ed164caa
Reviewed-on: https://chromium-review.googlesource.com/c/1391349
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#520}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/fc4f3f8b5160908dfc547c1d9ecf89ab44d81ba1/ash/app_list/views/search_result_answer_card_view.cc
[modify] https://crrev.com/fc4f3f8b5160908dfc547c1d9ecf89ab44d81ba1/content/browser/content_service_delegate_impl.cc
[modify] https://crrev.com/fc4f3f8b5160908dfc547c1d9ecf89ab44d81ba1/services/content/public/mojom/navigable_contents_factory.mojom

Status: Fixed (was: Assigned)

Sign in to add a comment