Answer card should have transparent background |
|||||||
Issue descriptionIt is using default white. As a result, we see strange gray on the right edge, which is the select/hover color partially shown. See attached screenshot.
,
Dec 20
This should be a duplicate of Issue 914887 which I have targeted for M72 (assuming a server side fix). Xiyuan, do you think your proposed fix is mergeable to M72? If so, I would like to change the target to M72.
,
Dec 20
Think we should be able to merge to M72.
,
Dec 20
,
Dec 20
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5ebe94b7ee85d5dbbcb82c945352b53401a5330 commit b5ebe94b7ee85d5dbbcb82c945352b53401a5330 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Fri Dec 21 19:24:04 2018 app_list: Answer card use transparent background - Support background color when creating navigable contents; - Answer card use transparent for its background color; Bug: 917166 Change-Id: Iea7b3449c6bed0eb7735f6b51ecee369f705220a Reviewed-on: https://chromium-review.googlesource.com/c/1387986 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#618571} [modify] https://crrev.com/b5ebe94b7ee85d5dbbcb82c945352b53401a5330/ash/app_list/views/search_result_answer_card_view.cc [modify] https://crrev.com/b5ebe94b7ee85d5dbbcb82c945352b53401a5330/content/browser/content_service_delegate_impl.cc [modify] https://crrev.com/b5ebe94b7ee85d5dbbcb82c945352b53401a5330/services/content/public/mojom/navigable_contents_factory.mojom
,
Dec 21
,
Dec 22
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 26
,
Dec 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc4f3f8b5160908dfc547c1d9ecf89ab44d81ba1 commit fc4f3f8b5160908dfc547c1d9ecf89ab44d81ba1 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Wed Dec 26 19:43:17 2018 Merge M72 "app_list: Answer card use transparent background" > - Support background color when creating navigable contents; > - Answer card use transparent for its background color; > > Bug: 917166 > Change-Id: Iea7b3449c6bed0eb7735f6b51ecee369f705220a > Reviewed-on: https://chromium-review.googlesource.com/c/1387986 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618571} > (cherry picked from commit b5ebe94b7ee85d5dbbcb82c945352b53401a5330) Change-Id: If151b88fd7ea8690a94bd4dfe0d86e73ed164caa Reviewed-on: https://chromium-review.googlesource.com/c/1391349 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#520} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/fc4f3f8b5160908dfc547c1d9ecf89ab44d81ba1/ash/app_list/views/search_result_answer_card_view.cc [modify] https://crrev.com/fc4f3f8b5160908dfc547c1d9ecf89ab44d81ba1/content/browser/content_service_delegate_impl.cc [modify] https://crrev.com/fc4f3f8b5160908dfc547c1d9ecf89ab44d81ba1/services/content/public/mojom/navigable_contents_factory.mojom
,
Dec 26
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by xiy...@chromium.org
, Dec 2057.9 KB
57.9 KB View Download