Set new test expectations for bidi caret affinity |
|
Issue descriptionWith bidi caret affinity enabled, caret can be displayed at a different visual location compared to the current behavior. We need to add new test expectations for all existing tests.
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffe5bf62c096bb86d140c02b5f1a4eb67fe2dd9f commit ffe5bf62c096bb86d140c02b5f1a4eb67fe2dd9f Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Fri Dec 21 00:16:16 2018 Convert editing/inserting/caret-position.html with W3C testharness This patch converts the web test with testharness to reduce usage of legacy editing.js. This is also a preparation for implementing bidi caret affinity. Bug: 917165 Change-Id: I84bbcba69f6a9dc768e92081b274146689635e28 Reviewed-on: https://chromium-review.googlesource.com/c/1388026 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#618395} [delete] https://crrev.com/246d85666a151d26eac19f9e910dcb4766239355/third_party/blink/web_tests/editing/inserting/caret-position-expected.txt [modify] https://crrev.com/ffe5bf62c096bb86d140c02b5f1a4eb67fe2dd9f/third_party/blink/web_tests/editing/inserting/caret-position.html
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b1f6c868d2a7758acf780517bcaa4def4bfc92e commit 8b1f6c868d2a7758acf780517bcaa4def4bfc92e Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Fri Dec 21 19:07:16 2018 Add bidi affinity expectations for editing/selection/offset-from-point*.html The layout tests assert visual caret positions, which is changed by the bidi caret affinity flag. This patch adds new behavior under the flag to make the test pass there. Bug: 917165 Change-Id: Id3e5f67cc4fe5021602484d9cb6d854489dd1e71 Reviewed-on: https://chromium-review.googlesource.com/c/1388205 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#618565} [modify] https://crrev.com/8b1f6c868d2a7758acf780517bcaa4def4bfc92e/third_party/blink/web_tests/TestExpectations [add] https://crrev.com/8b1f6c868d2a7758acf780517bcaa4def4bfc92e/third_party/blink/web_tests/virtual/bidi-caret-affinity/editing/selection/offset-from-point-complex-scripts-expected.txt [add] https://crrev.com/8b1f6c868d2a7758acf780517bcaa4def4bfc92e/third_party/blink/web_tests/virtual/bidi-caret-affinity/editing/selection/offset-from-point-expected.txt
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f019fc843447d7923fe7f28d8821e235adf1098 commit 8f019fc843447d7923fe7f28d8821e235adf1098 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Fri Dec 21 22:17:32 2018 Add bidi affinity behavior for editing/caret/caret-direction-auto.html The layout test asserts visual caret positions, which is changed by the bidi caret affinity flag. This patch adds new behavior under the flag to make the test pass there. Bug: 917165 Change-Id: I801d11574658ab9efcd18d284187db08d669c1e3 Reviewed-on: https://chromium-review.googlesource.com/c/1388024 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#618629} [modify] https://crrev.com/8f019fc843447d7923fe7f28d8821e235adf1098/third_party/blink/web_tests/TestExpectations [modify] https://crrev.com/8f019fc843447d7923fe7f28d8821e235adf1098/third_party/blink/web_tests/editing/caret/caret-direction-auto.html
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a2de5ee208f9d2f58240a64869a792aa930a23a commit 2a2de5ee208f9d2f58240a64869a792aa930a23a Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Fri Dec 21 22:27:13 2018 Remove virtual/bidi-caret-affinity/editing/selection/modify_extend/extend_by_character.html from "true failures" The web test is already flaky on Mac and Win even without the bidi caret affinity flag. Hence, this patch moves it from the "true failures" section to the "already failing" section. Bug: 917165 Change-Id: I01f06cbf13009504af6d3a908564b3e5a96f2d79 Reviewed-on: https://chromium-review.googlesource.com/c/1388719 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#618635} [modify] https://crrev.com/2a2de5ee208f9d2f58240a64869a792aa930a23a/third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/2a2de5ee208f9d2f58240a64869a792aa930a23a/third_party/blink/web_tests/TestExpectations
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/114a80d9a90fe63cc4ebcf94158b29e24bf930e9 commit 114a80d9a90fe63cc4ebcf94158b29e24bf930e9 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Fri Dec 21 22:29:49 2018 Add bidi affinity expectations for editing/selection/caret-{ltr,rtl}-2[-left].html The layout tests assert mapping between logical and visual caret positions, which is changed by the bidi caret affinity flag. This patch adds new behavior under the flag to make the tests pass there. Bug: 917165 Change-Id: I273d1194e7f011deccb05d33d2a3304b03bfd90a Reviewed-on: https://chromium-review.googlesource.com/c/1388810 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#618636} [modify] https://crrev.com/114a80d9a90fe63cc4ebcf94158b29e24bf930e9/third_party/blink/web_tests/TestExpectations [modify] https://crrev.com/114a80d9a90fe63cc4ebcf94158b29e24bf930e9/third_party/blink/web_tests/editing/selection/caret-ltr-2-left.html [modify] https://crrev.com/114a80d9a90fe63cc4ebcf94158b29e24bf930e9/third_party/blink/web_tests/editing/selection/caret-ltr-2.html [modify] https://crrev.com/114a80d9a90fe63cc4ebcf94158b29e24bf930e9/third_party/blink/web_tests/editing/selection/caret-rtl-2-left.html [modify] https://crrev.com/114a80d9a90fe63cc4ebcf94158b29e24bf930e9/third_party/blink/web_tests/editing/selection/caret-rtl-2.html
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef2d6f040e7ae1fa50a593b47f2f790a0bb9cc0b commit ef2d6f040e7ae1fa50a593b47f2f790a0bb9cc0b Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Fri Dec 21 22:34:16 2018 Add bidi affinity behavior for editing/selection/caret-at-bidi-boundary.html The layout test asserts visual caret positions, which is changed by the bidi caret affinity flag. This patch adds new behavior under the flag to make the test pass there. Bug: 917165 Change-Id: I6bcbff036d8239c66e62c19bbc1170b725b11d89 Reviewed-on: https://chromium-review.googlesource.com/c/1387478 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#618638} [modify] https://crrev.com/ef2d6f040e7ae1fa50a593b47f2f790a0bb9cc0b/third_party/blink/web_tests/SlowTests [modify] https://crrev.com/ef2d6f040e7ae1fa50a593b47f2f790a0bb9cc0b/third_party/blink/web_tests/TestExpectations [modify] https://crrev.com/ef2d6f040e7ae1fa50a593b47f2f790a0bb9cc0b/third_party/blink/web_tests/editing/selection/caret-at-bidi-boundary.html [add] https://crrev.com/ef2d6f040e7ae1fa50a593b47f2f790a0bb9cc0b/third_party/blink/web_tests/virtual/bidi-caret-affinity/editing/selection/caret-at-bidi-boundary-expected.txt
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b9f72b9934d39300d292432607a0dd08ff12045 commit 1b9f72b9934d39300d292432607a0dd08ff12045 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Fri Dec 21 23:07:17 2018 Add bidi affinity expectation for editing/style/text-indent.html The layout test asserts mapping between logical and visual caret positions, which is changed by the bidi caret affinity flag. This patch adds new behavior under the flag to make the test pass there. Bug: 917165 Change-Id: I0494f08b7af5ddce7eeff0aff43348d84efa1931 Reviewed-on: https://chromium-review.googlesource.com/c/1388815 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#618655} [modify] https://crrev.com/1b9f72b9934d39300d292432607a0dd08ff12045/third_party/blink/web_tests/TestExpectations [modify] https://crrev.com/1b9f72b9934d39300d292432607a0dd08ff12045/third_party/blink/web_tests/editing/style/text-indent.html
,
Dec 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f64725da8d130ba4949a646f24c1e3eaaf6c2d8f commit f64725da8d130ba4949a646f24c1e3eaaf6c2d8f Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Tue Dec 25 11:19:39 2018 Add bidi affinity behavior for editing/inserting/caret-position.html The layout test asserts visual caret positions, which is changed by the bidi caret affinity flag. This patch adds new behavior under the flag to make the test pass there. Bug: 917165 Change-Id: I21691beadedbf1ce23f3c446a53c31ce247a988d Reviewed-on: https://chromium-review.googlesource.com/c/1389027 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#618858} [modify] https://crrev.com/f64725da8d130ba4949a646f24c1e3eaaf6c2d8f/third_party/blink/web_tests/TestExpectations [modify] https://crrev.com/f64725da8d130ba4949a646f24c1e3eaaf6c2d8f/third_party/blink/web_tests/editing/inserting/caret-position.html
,
Dec 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30525a6f3263a92dc664c50dbdf6b889dc3c36c8 commit 30525a6f3263a92dc664c50dbdf6b889dc3c36c8 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Tue Dec 25 11:19:43 2018 Add bidi affinity expectation for editing/selection/caret-bidi-first-and-last-letters.html The layout test asserts hit test results at bidi boundaries, which are hanged by the bidi caret affinity flag. This patch adds new behavior under the flag to make the test pass there. Bug: 917165 Change-Id: I171a2fab751a033bd624233b0bfba3746cbdcaa3 Reviewed-on: https://chromium-review.googlesource.com/c/1389160 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#618859} [modify] https://crrev.com/30525a6f3263a92dc664c50dbdf6b889dc3c36c8/third_party/blink/web_tests/editing/selection/caret-bidi-first-and-last-letters.html
,
Dec 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/872da7efb13000a7a7515054b1b5a6be7b4f0e56 commit 872da7efb13000a7a7515054b1b5a6be7b4f0e56 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Wed Dec 26 19:48:21 2018 Remove a leftover failure expectation Patch crrev.com/c/1389160 has made virtual/bidi-caret-affinity/editing/selection/caret-bidi-first-and-last-letters.html pass, but didn't remove the failure expectation line. This patch does it. Tbr: eae@chromium.org Bug: 917165 Change-Id: I073f0cc30c27e6aa092eba2db3d4baae1bcb6524 Reviewed-on: https://chromium-review.googlesource.com/c/1391309 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#618951} [modify] https://crrev.com/872da7efb13000a7a7515054b1b5a6be7b4f0e56/third_party/blink/web_tests/TestExpectations |
|
►
Sign in to add a comment |
|
Comment 1 by xiaoche...@chromium.org
, Dec 20