New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 917152 link

Starred by 1 user
Status: Fixed
Owner:
liaoyuke@chromium.org
Closed: Dec 21
Cc:
█ robert...@chromium.org
liaoyuke@chromium.org
mmoroz@chromium.org
infe...@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 915811



Sign in to add a comment

Coverage annotation is not shown if an user clicks a file or 'Expand All' too fast

Project Member Reported by liaoyuke@chromium.org, Dec 20 
Steps to repro:
1. Go to https://chromium-review.googlesource.com/c/chromium/src/+/1369646
2. Immediate click on a file or click on the 'Expand All'.

What happens:
The annotations fail to load.

Root cause:
The reason is that the plugin fetches coverage data in exponential backoff manner, and the start sleep time is too long (2 seconds), which causes 2 seconds delay on the first fetch attempt, and if the user opens a file within 2 seconds, the coverage data won't be shown.

The solution is to increase the start sleep time.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/code-coverage/+/4ae39dd9a86569796dcba7dcaf3af3947d1fe35e

commit 4ae39dd9a86569796dcba7dcaf3af3947d1fe35e
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Fri Dec 21 17:43:32 2018

[code coverage] Decrease start sleep time

There was a racing condition that when the user clicks a file or
'Expand All' too fast, the coverage data won't be shown.

This CL fixes the issue by decreasing the start sleep time to make the
plugin attempts fetching coverage data more frequently at first, and
given that the exponential backoff behavior is maintained, the
increased overhead is negligible.

Bug:  917152 
Change-Id: I4e0b0d5639ba4d8dd50cf84896d583aa9fee7549
[modify] https://crrev.com/4ae39dd9a86569796dcba7dcaf3af3947d1fe35e/src/main/resources/static/chromium-coverage.html

Comment 2 by liaoyuke@chromium.org, Dec 21

Status: Fixed (was: Started)
►

Sign in to add a comment