New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 917123 link

Starred by 5 users
Status: Fixed
Owner:
jinsuk...@chromium.org
Closed: Jan 9
Cc:
█ donnd@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

[Ephemeral Tab] Consider making it easy to open into a new Tab

Project Member Reported by donnd@chromium.org, Dec 20 
A recent news report on Sneak peek laments that it's not easy to make it into a new Tab.  https://www.androidauthority.com/google-chrome-android-sneak-peek-936075/

TTS does this by allowing tap on the Bar of the expanded panel to promote into a new Tab, so it should be easy to do the same for ET.

Comment 1 by jinsuk...@chromium.org, Dec 20 

Yes I think it's easy - it was just not in the initial design doc :)

Comment 2 by jinsuk...@chromium.org, Jan 3

Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb8b5fef4939cf4fd21b41ab2e6911618714f35a

commit bb8b5fef4939cf4fd21b41ab2e6911618714f35a
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue Jan 08 23:48:35 2019

EphemeralTab: Promote to a new tab

This CL adds UI promoting an ephemeral tab to a full new tab
upon clicking its bar in maximized mode, like contextual search panel
does. Also adds a caption view saying "Open in a new tab" that gets
visible as the panel goes to maximized mode.

Bug:  917123 
Change-Id: Ia52aa47d97cb3926f86326c93066f65045b593a2
Reviewed-on: https://chromium-review.googlesource.com/c/1392697
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620941}
[add] https://crrev.com/bb8b5fef4939cf4fd21b41ab2e6911618714f35a/chrome/android/java/res/layout/ephemeral_tab_caption_view.xml
[modify] https://crrev.com/bb8b5fef4939cf4fd21b41ab2e6911618714f35a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/ephemeraltab/EphemeralTabBarControl.java
[add] https://crrev.com/bb8b5fef4939cf4fd21b41ab2e6911618714f35a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/ephemeraltab/EphemeralTabCaptionControl.java
[modify] https://crrev.com/bb8b5fef4939cf4fd21b41ab2e6911618714f35a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/ephemeraltab/EphemeralTabPanel.java
[add] https://crrev.com/bb8b5fef4939cf4fd21b41ab2e6911618714f35a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/ephemeraltab/EphemeralTabTitleControl.java
[modify] https://crrev.com/bb8b5fef4939cf4fd21b41ab2e6911618714f35a/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/EphemeralTabSceneLayer.java
[modify] https://crrev.com/bb8b5fef4939cf4fd21b41ab2e6911618714f35a/chrome/android/java_sources.gni
[modify] https://crrev.com/bb8b5fef4939cf4fd21b41ab2e6911618714f35a/chrome/browser/android/compositor/layer/ephemeral_tab_layer.cc
[modify] https://crrev.com/bb8b5fef4939cf4fd21b41ab2e6911618714f35a/chrome/browser/android/compositor/layer/ephemeral_tab_layer.h
[modify] https://crrev.com/bb8b5fef4939cf4fd21b41ab2e6911618714f35a/chrome/browser/android/compositor/scene_layer/ephemeral_tab_scene_layer.cc
[modify] https://crrev.com/bb8b5fef4939cf4fd21b41ab2e6911618714f35a/chrome/browser/android/compositor/scene_layer/ephemeral_tab_scene_layer.h

Comment 4 by jinsuk...@chromium.org, Jan 9

Status: Fixed (was: Started)
►

Sign in to add a comment