Improve or re-enable tests which broke with Mojo dispatch changes |
||
Issue descriptionSeveral tests in various test suites were broken by https://chromium-review.googlesource.com/c/chromium/src/+/1145692 In the interest of landing that change and stopping the endless game of whack-a-mole that landing it has become, these tests have been either "fixed" using cheesy hacks like RunUntilIdle() peppering, or outright disabled due to the perceived complexity of a proper fix. All such tests have been annotated in the tree with this bug reference using the canonical "https://crbug.com/######" form.
,
Jan 11
Available, but no owner or component? Please find a component, as no one will ever find this without one.
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/550d5a768e5efdb3f81d472f42dfd59bb5b83b1d commit 550d5a768e5efdb3f81d472f42dfd59bb5b83b1d Author: Ken Rockot <rockot@google.com> Date: Wed Jan 16 19:04:20 2019 Fix or disable tests with bad timing expectations This disables a few tests which fail when attempting to land https://chromium-review.googlesource.com/c/chromium/src/+/1145692. That CL ends up changing Mojo bindings dispatch timing in subtle but valid ways, and as such it should not actually break any correct tests. These tests should be fixed and re-enabled ASAP after the Mojo change is landed. Bug: 866708,917113 Change-Id: Ib97dbe312562adc0e02eb61c323386836bcb44f5 Reviewed-on: https://chromium-review.googlesource.com/c/1388172 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Dmitry Titov <dimich@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#623318} [modify] https://crrev.com/550d5a768e5efdb3f81d472f42dfd59bb5b83b1d/ash/highlighter/highlighter_controller_unittest.cc [modify] https://crrev.com/550d5a768e5efdb3f81d472f42dfd59bb5b83b1d/ash/magnifier/magnification_controller_unittest.cc [modify] https://crrev.com/550d5a768e5efdb3f81d472f42dfd59bb5b83b1d/chrome/browser/offline_pages/offline_page_request_handler_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by rockot@google.com
, Dec 20