Issue metadata
Sign in to add a comment
|
Enable the WebViewUmaLogAppPackageName by default |
||||||||||||||||||||
Issue descriptionEnable the WebViewUmaLogAppPackageName by default in m72, we will use finch experiment to see if it could be disabled.
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f73e38dd11c8afb103f2b51c65466c71d5415976 commit f73e38dd11c8afb103f2b51c65466c71d5415976 Author: Tao Bai <michaelbai@chromium.org> Date: Thu Dec 20 21:43:08 2018 Enable the WebViewUmaLogAppPackageName by default Bug: 917112 Change-Id: Idcfac659688b33f48d4dede027cf56173a1e4414 Reviewed-on: https://chromium-review.googlesource.com/c/1387665 Reviewed-by: Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#618337} [modify] https://crrev.com/f73e38dd11c8afb103f2b51c65466c71d5415976/android_webview/browser/aw_feature_list.cc
,
Dec 20
,
Dec 20
could you add issue dependencies?
,
Dec 20
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 20
Pls update bug with canary result tomorrow, also pls provide M72 merge justification. Thank you.
,
Dec 21
The NextAction date has arrived: 2018-12-21
,
Dec 21
govind@ I checked 73.0.3647.0 and didn't see any issue, the feature is in M71 but disabled by default, QA team already turned it on locally when they tested M71 and M72, we tried to turned it on by finch for M72 Beta, for some reason, the feature wasn't turned on, so we decided to enabled it by default, in the meanwhile, we will find finch's issue.
,
Dec 21
Approving merge to M72 branch 3626 based on comment #8. Are you planning to revert this change (enabling by default) from M72 after Finch issue is resolved?
,
Dec 21
Pls merge your change to M72 branch 3626 ASAP. Thank you.
,
Dec 21
Re #9, No, it will not be reverted, if finch issue is fix, we could use it to disable the feature once something bad happen.
,
Dec 21
Ok, sounds good. Thank you.
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edd4393b639feedac9bc3fdf6a37953b71232c7d commit edd4393b639feedac9bc3fdf6a37953b71232c7d Author: Tao Bai <michaelbai@chromium.org> Date: Fri Dec 21 20:34:28 2018 Enable the WebViewUmaLogAppPackageName by default Bug: 917112 Change-Id: Idcfac659688b33f48d4dede027cf56173a1e4414 Reviewed-on: https://chromium-review.googlesource.com/c/1387665 Reviewed-by: Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#618337}(cherry picked from commit f73e38dd11c8afb103f2b51c65466c71d5415976) Reviewed-on: https://chromium-review.googlesource.com/c/1388711 Reviewed-by: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#503} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/edd4393b639feedac9bc3fdf6a37953b71232c7d/android_webview/browser/aw_feature_list.cc
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edd4393b639feedac9bc3fdf6a37953b71232c7d Commit: edd4393b639feedac9bc3fdf6a37953b71232c7d Author: michaelbai@chromium.org Commiter: michaelbai@chromium.org Date: 2018-12-21 20:34:28 +0000 UTC Enable the WebViewUmaLogAppPackageName by default Bug: 917112 Change-Id: Idcfac659688b33f48d4dede027cf56173a1e4414 Reviewed-on: https://chromium-review.googlesource.com/c/1387665 Reviewed-by: Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#618337}(cherry picked from commit f73e38dd11c8afb103f2b51c65466c71d5415976) Reviewed-on: https://chromium-review.googlesource.com/c/1388711 Reviewed-by: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#503} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 21
,
Jan 8
Marking Verified/Fixed , Check with michaelbai@, UMA is enalbe by default. Test team did not come across any issue while testing the UMA features as well |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by michaelbai@chromium.org
, Dec 20