New issue
Advanced search Search tips

Issue 917106 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 765435

Blocking:
issue 916548



Sign in to add a comment

Swarming: push CATEGORY_NEVER_RAN_DONE TaskResult to BigQuery

Project Member Reported by mar...@chromium.org, Dec 20

Issue description

Right now only TaskRunResult are pushed to the BQ table swarming.task_results.
It is also good to get results about tasks that were *not* run, but in such case there is no TaskRunResult created.

AI:
- Query for all TaskResultSummary that are complete but without a TaskRunResult (?)
- Push them to swarming.task_results.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/d8e3e988330ca1b5bb6e332853d0319f43188a72

commit d8e3e988330ca1b5bb6e332853d0319f43188a72
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Fri Dec 21 21:05:57 2018

[swarming] Add TaskResult message and all necessary submessages

They are not used yet. The proto change is done in a separate CL because this is
already large enough.

This will be needed when streaming the task results to BigQuery. We expect the
use of the same format than the API.

Include a small crash fix in TaskRequest.to_proto().

Bug: 917106
Bug: 870723
Change-Id: Ifa3a88dbf66bcbc5b862cdb14124bec55a1ba4b2
Reviewed-on: https://chromium-review.googlesource.com/c/1379351
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/d8e3e988330ca1b5bb6e332853d0319f43188a72/appengine/swarming/proto/api/plugin_prpc_pb2.py
[modify] https://crrev.com/d8e3e988330ca1b5bb6e332853d0319f43188a72/appengine/swarming/proto/api/swarming.proto
[modify] https://crrev.com/d8e3e988330ca1b5bb6e332853d0319f43188a72/appengine/swarming/proto/api/swarming_pb2.py
[modify] https://crrev.com/d8e3e988330ca1b5bb6e332853d0319f43188a72/appengine/swarming/proto/api/swarming_prpc_pb2.py
[modify] https://crrev.com/d8e3e988330ca1b5bb6e332853d0319f43188a72/appengine/swarming/server/task_request.py
[modify] https://crrev.com/d8e3e988330ca1b5bb6e332853d0319f43188a72/appengine/swarming/server/task_result.py
[modify] https://crrev.com/d8e3e988330ca1b5bb6e332853d0319f43188a72/appengine/swarming/server/task_result_test.py

Sign in to add a comment