New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 917100 link

Starred by 1 user
Status: WontFix
Owner:
thomasanderson@chromium.org
Closed: Dec 20
Cc:
agrieve@chromium.org
█ wnwen@chromium.org
thakis@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

69.9KiB regression in resource_sizes (MonochromePublic.apk) at 618079:618079

Project Member Reported by wnwen@chromium.org, Dec 20 
Caused by “Build with _LIBCPP_ABI_UNSTABLE”

Commit: 0f0b0a857e911b152d694c20852b2424ce7868da

Link to size graph: https://chromeperf.appspot.com/report?sid=bb23072657e2d7ca892a1c3fa4643b1ee29b3a0a44d0732adda87168e89c0380&num_points=10&rev=618079
Link to trybot result: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-binary-size/122983

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on the graph: entirely native lib size

It's not clear to me whether or not this increase was expected.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.

It typically takes about a week of engineering time to reduce binary size by 100kb so we'd really appreciate you taking some time exploring options to address this regression!
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 20 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=917100

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=38a595ab59eb93e431c2a5fef575f182a0766440acf4b25dd0a7c881682cb069


Bot(s) for this bug's original alert(s):

Android Builder Perf
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Dec 20 

Assigning to thomasanderson@chromium.org because this is the only CL in range:
Build with _LIBCPP_ABI_UNSTABLE

BUG= 747676 
R=thakis

Change-Id: Ib3e8d058b380764ee55de77b5993b3ecbf7137e9
Reviewed-on: https://chromium-review.googlesource.com/c/1379066
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618079}

Comment 3 by thomasanderson@chromium.org, Dec 20

Status: WontFix (was: Assigned)
_LIBCPP_ABI_UNSTABLE adds some more code to c++ templates like vector and string that get instantiated everywhere so I'm not surprised the binary size increased.  I think overall it should be worth it given the potential runtime benefits.
►

Sign in to add a comment