New issue
Advanced search Search tips

Issue 917086 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

base_unittests "SysInfoTest.GetHardwareInfo" fails on a CrOS device

Project Member Reported by bpastene@chromium.org, Dec 20

Issue description

See https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/chromeos-kevin-rel-hw-tests/7240 which runs a class of tests on chromebooks (a testing platform we're trying to spin up as part of bug 866062)

SysInfoTest.GetHardwareInfo currently fails with:
[  FAILED  ] SysInfoTest.GetHardwareInfo (32 ms)
[ RUN      ] SysInfoTest.GetHardwareInfo
../../base/system/sys_info_unittest.cc:162: Failure
Expected equality of these values:
  hardware_info->manufacturer.empty()
    Which is: true
  empty_result_expected
    Which is: false
Stack trace:
#0 0x000009589e6e testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x0000095899ba testing::internal::AssertHelper::operator=()
#2 0x000009361cb0 base::SysInfoTest_GetHardwareInfo_Test::TestBody()

From https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8926597746623722752/+/steps/base_unittests_on_ChromeOS/0/logs/SysInfoTest.GetHardwareInfo/0

If this suite provides little value on cros hardware, go ahead and mark as wontfix. Otherwise, I'll leave it on the bot and disable the test for now.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0faff696a9c0e588f9f17b19828228f52af3107f

commit 0faff696a9c0e588f9f17b19828228f52af3107f
Author: Ben Pastene <bpastene@chromium.org>
Date: Fri Dec 21 22:10:26 2018

Add a filter file to base_unittests running on the cros hardware bot.

And disable the one failing test.

Bug: 917086
Change-Id: I3abc37faef3b2c5fb182075b48737c3e512d8e72
Reviewed-on: https://chromium-review.googlesource.com/c/1387548
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618625}
[modify] https://crrev.com/0faff696a9c0e588f9f17b19828228f52af3107f/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/0faff696a9c0e588f9f17b19828228f52af3107f/testing/buildbot/filters/BUILD.gn
[add] https://crrev.com/0faff696a9c0e588f9f17b19828228f52af3107f/testing/buildbot/filters/chromeos.base_unittests.filter
[modify] https://crrev.com/0faff696a9c0e588f9f17b19828228f52af3107f/testing/buildbot/test_suites.pyl

Sign in to add a comment