New issue
Advanced search Search tips

Issue 917072 link

Starred by 3 users
Status: Fixed
Owner:
aee@chromium.org
Closed: Dec 28
Cc:
viswa.karala@chromium.org
swarnasree.mukkala@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Content allow/block settings are now harder to search

Reported by kpreid.s...@gmail.com, Dec 20 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce the problem:
1. Go to an allow/block settings page like chrome://settings/content/microphone or chrome://settings/content/javascript
2. Press Cmd-F (/ Ctrl-F).

What is the expected behavior?
I can type to search the allow/block list by site name.

What went wrong?
Focus jumps to the general settings search bar, which is useless for this purpose. Previously, Cmd-F would activate the find in page function, which works fine for finding allow/block entries.

Did this work before? Yes 

Chrome version: 71.0.3578.98  Channel: stable
OS Version: OS X 10.13.6
Flash Version: 

Please either add a search field like the chrome://settings/siteData page has or remove the binding of Cmd-F for this type of settings page for the time being.

Comment 1 by gov...@chromium.org, Dec 20

Labels: Needs-Triage-M71

Comment 2 by swarnasree.mukkala@chromium.org, Dec 21

Cc: swarnasree.mukkala@chromium.org
Components: -UI UI>Settings
Labels: -Pri-2 hasbisect-per-revision RegressedIn-70 Triaged-ET Target-71 Target-72 Target-73 M-73 FoundIn-71 FoundIn-73 FoundIn-72 OS-Linux OS-Windows Pri-1
Owner: aee@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported chrome version #71.0.3578.98 and latest chrome #73.0.3646.0 using Mac OS 10.13.6, Ubuntu 17.10 and Windows 10 by following steps as per comment#0

Bisect Information:
===================
Good Build: 70.0.3507.0
Bad Build: 70.0.3508.0

You are probably looking for a change made after 579224 (known good), but no later than 579225 (first known bad).
CHANGELOG URL:https://chromium.googlesource.com/chromium/src/+log/23d74207a325d0ed322736fdee145e8786055711..8707c01bdbaef12bb57972a40bffef7eed04187b
Reviewed-on: https://chromium-review.googlesource.com/1141157

@Esmael El-Moslimany: Please help us in reassigning the issue if it is not related to your change.
Thanks.!

Comment 3 by aee@chromium.org, Dec 21

Status: Started (was: Assigned)

Comment 4 by dpa...@chromium.org, Dec 21 

@aee: How are you planning to address this?

Comment 5 by aee@chromium.org, Dec 21 

I plan to add subpage search to these subpages similar to the password page. https://chromium-review.googlesource.com/c/chromium/src/+/1388721

Comment 6 by viswa.karala@chromium.org, Dec 26

Cc: viswa.karala@chromium.org
 Issue 917775  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9a7620f4486d34b8528af457ead65cf514bed5e

commit d9a7620f4486d34b8528af457ead65cf514bed5e
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Dec 28 02:58:43 2018

Settings WebUI: add subpage search to site settings pages

When navigating to site-data from the cookies page, site-data registers
as a listeners before cookies page unregisters. The options are to
coordinate the register/unregister between subpages or relax the
removal logic assertion in FindShortcutBehavior. I opted for the second
approach.

Bug:  917072 
Change-Id: I981e035b481850a5921adfb89e00b748a3d1a446
Reviewed-on: https://chromium-review.googlesource.com/c/1388721
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619109}
[modify] https://crrev.com/d9a7620f4486d34b8528af457ead65cf514bed5e/chrome/browser/resources/settings/find_shortcut_behavior.js
[modify] https://crrev.com/d9a7620f4486d34b8528af457ead65cf514bed5e/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/d9a7620f4486d34b8528af457ead65cf514bed5e/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/d9a7620f4486d34b8528af457ead65cf514bed5e/chrome/browser/resources/settings/settings_page/settings_subpage.js
[modify] https://crrev.com/d9a7620f4486d34b8528af457ead65cf514bed5e/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/d9a7620f4486d34b8528af457ead65cf514bed5e/chrome/browser/resources/settings/site_settings/category_setting_exceptions.html
[modify] https://crrev.com/d9a7620f4486d34b8528af457ead65cf514bed5e/chrome/browser/resources/settings/site_settings/category_setting_exceptions.js
[modify] https://crrev.com/d9a7620f4486d34b8528af457ead65cf514bed5e/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/d9a7620f4486d34b8528af457ead65cf514bed5e/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/d9a7620f4486d34b8528af457ead65cf514bed5e/chrome/test/data/webui/settings/find_shortcut_behavior_test.js
[modify] https://crrev.com/d9a7620f4486d34b8528af457ead65cf514bed5e/chrome/test/data/webui/settings/site_list_tests.js

Comment 8 by aee@chromium.org, Dec 28

Status: Fixed (was: Started)

Comment 9 by viswa.karala@chromium.org, Dec 28 

 Issue 918040  has been merged into this issue.
►

Sign in to add a comment