split divider is not place on top correctly if the dragged tab is merged into another browser window |
|||||||||
Issue descriptionChrome Version: 73.0.3641.0 OS: Chrome What steps will reproduce the problem? (1) Open a few browser windows and enter tablet mode (2) Snap two browser windows side by side (3) Drag on the tab of one browser window and merge the window into another browser window. Notice that the tab is merged into another browser window. Splitview mode and overview mode are both active at the same time. What is the expected result? The split divider bar should placed on top to receive events What happens instead? The split divider bar is not placed on top
,
Dec 20
,
Dec 20
This issue might cause the split divider bar can't be used to resize snapped windows in split screen, thus request merge-back.
,
Dec 21
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 26
,
Dec 31
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 3
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0508a52e67e7628f6f07be01227ca1ea0ad3ed3 commit b0508a52e67e7628f6f07be01227ca1ea0ad3ed3 Author: Xiaoqian Dai <xdai@chromium.org> Date: Mon Jan 14 22:25:47 2019 [Merge to M72] splitview: The divider bar should be placed on top after tab dragging ends. If a tab-dragged browser window is merged into another browser window after the drag ends, we need to make sure the divider bar is placed properly on top. Otherwise, it may not receive events properly. Bug: 917068 TBR=xiyuan@chromium.org Change-Id: I1f19d9e7a94427e47b91a9c8b5b037dda3e2f1b8 Reviewed-on: https://chromium-review.googlesource.com/c/1387468 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#618340}(cherry picked from commit 097d8d6efc117b1fecb4e7db16694a45ed074113) Reviewed-on: https://chromium-review.googlesource.com/c/1410128 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#680} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/b0508a52e67e7628f6f07be01227ca1ea0ad3ed3/ash/wm/splitview/split_view_controller.cc [modify] https://crrev.com/b0508a52e67e7628f6f07be01227ca1ea0ad3ed3/ash/wm/splitview/split_view_controller.h [modify] https://crrev.com/b0508a52e67e7628f6f07be01227ca1ea0ad3ed3/ash/wm/splitview/split_view_controller_unittest.cc
,
Jan 14
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision b0508a52e67e7628f6f07be01227ca1ea0ad3ed3 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0508a52e67e7628f6f07be01227ca1ea0ad3ed3 Commit: b0508a52e67e7628f6f07be01227ca1ea0ad3ed3 Author: xdai@chromium.org Commiter: xdai@chromium.org Date: 2019-01-14 22:25:47 +0000 UTC [Merge to M72] splitview: The divider bar should be placed on top after tab dragging ends. If a tab-dragged browser window is merged into another browser window after the drag ends, we need to make sure the divider bar is placed properly on top. Otherwise, it may not receive events properly. Bug: 917068 TBR=xiyuan@chromium.org Change-Id: I1f19d9e7a94427e47b91a9c8b5b037dda3e2f1b8 Reviewed-on: https://chromium-review.googlesource.com/c/1387468 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#618340}(cherry picked from commit 097d8d6efc117b1fecb4e7db16694a45ed074113) Reviewed-on: https://chromium-review.googlesource.com/c/1410128 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#680} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 20