New issue
Advanced search Search tips

Issue 916998 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Theme color #feede2 does not work

Reported by yerzhan....@gmail.com, Dec 20

Issue description

Steps to reproduce the problem:
1. Insert the tag <meta name="theme-color" content="#feede2"> into a page;
2. open the page in Chrome for Android;
3. toolbar (address bar) doesn't get colored.

What is the expected behavior?
Toolbar gets colored.

What went wrong?
Toolbar hasn't been painted by the color (#feede2).

Did this work before? N/A 

Chrome version: 71.0.3578.99  Channel: stable
OS Version: 7.0
Flash Version: 

Other colors (at least that are used in the site) do work.
 
Labels: Needs-triage-Mobile
Cc: chelamcherla@chromium.org
Labels: Triaged-Mobile Needs-Feedback
@ yerzhan.tulepov: Please provide test URL with above mentioned tag along with device details on which this issue is seen. This would help in further triaging of the issue.

Thanks!
@ chelamcherla: Production url is https://azan.ru
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 21

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
The issue is seen on Xiaomi Redmi Note 5.
And as far as I know it exists on Samsung (of my manager) as well. I don't know the exact model.
Components: -UI UI>Browser>Toolbar
Labels: Target-73 M-73 FoundIn-73
Status: Untriaged (was: Unconfirmed)
Tested the issue in Android and able to reproduce the issue. 

Steps Followed:
1. Navigated to https://azan.ru
2. Theme color is bot applied to toolbar

Chrome versions tested:
71.0.3578.99 , 73.0.3649.0

OS:
Android 9.0.0

Android Devices:
Pixel XL

Issue is seen from older M-60 builds, hence considering this as Non-Regression and marking as Untriaged.

Thanks!
Hi @chelamcherla,

Thanks for confirmation of the bug. On azan.ru the theme-color is dynamic, i.e. it changes 6 times a day. If you've confirmed the issue may I revert that (dynamic changing of toolbar's color) behaviour?

Regard,
Y.
Labels: clank-fe-triaged
Owner: peconn@chromium.org
Status: Assigned (was: Untriaged)
Status: WontFix (was: Assigned)
Hello Yerzhan,

Yes, you can resume changing the theme colour.

Chrome will only use theme colours if they are dark enough to ensure there's enough contrast on the UI. Basically, it performs this calculation:

largest = max(color.red, color.green, color.blue);
smallest = min(color.red, color.green, color.blue);
average = (largest + smallest) / 2;
luminance = average / 255

And it will use the theme colour if luminance is <= 0.94.

If you're interested you can see the code used to check this in 'isValidThemeColor' and 'getLightnessForColor' in 'ColorUtils.java' at https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java .

I'm going to close this bug since it's working as intended, but feel free respond if you have further questions.

Peter
Hello Peter!

Appreciate you for the valuable info.

Regards,
Y.

Sign in to add a comment