New issue
Advanced search Search tips

Issue 916990 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

hpack 64 bit truncation errors

Project Member Reported by dtapu...@chromium.org, Dec 20

Issue description

In trying to enable 64 bit truncation errors for blink we are running into some truncation warnings in the hpack headers.

vasilvv@ is this something you can fix? Since you fixed some signed/unsigned issues earlier this month in this code.


../../net/third_party/quiche/src/http2/hpack/decoder/hpack_entry_type_decoder.h:41:52: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
  uint32_t varint() const { return varint_decoder_.value(); }
                            ~~~~~~ ~~~~~~~~~~~~~~~~^~~~~~~
In file included from ../../third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_stream_unittest.cc:8:
In file included from ../../net/third_party/quic/test_tools/quic_test_utils.h:20:
In file included from ../../net/third_party/quic/core/http/quic_client_push_promise_index.h:8:
In file included from ../../net/third_party/quic/core/http/quic_spdy_client_session_base.h:9:
In file included from ../../net/third_party/quic/core/http/quic_spdy_session.h:19:
In file included from ../../net/third_party/spdy/core/http2_frame_decoder_adapter.h:15:
In file included from ../../net/third_party/spdy/core/hpack/hpack_decoder_adapter.h:17:
In file included from ../../net/third_party/quiche/src/http2/hpack/decoder/hpack_decoder.h:27:
In file included from ../../net/third_party/quiche/src/http2/hpack/decoder/hpack_block_decoder.h:16:
In file included from ../../net/third_party/quiche/src/http2/hpack/decoder/hpack_entry_decoder.h:18:
../../net/third_party/quiche/src/http2/hpack/decoder/hpack_string_decoder.h:171:34: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'size_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
    remaining_ = length_decoder_.value();

 
Cc: b...@chromium.org
Cc: -b...@chromium.org
Owner: b...@chromium.org
Status: Started (was: Untriaged)

Sign in to add a comment