New issue
Advanced search Search tips

Issue 916975 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Tests need manual rebaseline to fix arrow function name inferring

Project Member Reported by verwa...@chromium.org, Dec 20

Issue description

external/wpt/workers/semantics/structured-clone/dedicated.html
external/wpt/workers/semantics/structured-clone/shared.html
http/tests/devtools/console/console-repeat-count.js
http/tests/devtools/service-workers/lazy-addeventlisteners.js
http/tests/devtools/sources/debugger-ui/call-stack-show-more.js
http/tests/devtools/tracing/timeline-misc/timeline-event-causes.js
inspector-protocol/css/media-query-listener-exception.js
virtual/omt-worker-fetch/external/wpt/workers/semantics/structured-clone/dedicated.html
virtual/omt-worker-fetch/external/wpt/workers/semantics/structured-clone/shared.html
virtual/threaded/http/tests/devtools/tracing/timeline-misc/timeline-event-causes.js
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daa412537ed3389d4a5efe82c13ef8f8835c5548

commit daa412537ed3389d4a5efe82c13ef8f8835c5548
Author: Toon Verwaest <verwaest@chromium.org>
Date: Thu Dec 20 14:14:26 2018

Disable tests to change arrow function name inferring

Temporarily disable. Will reenable after V8 sticks with the change to
function name inferring of arrow functions.

Bug: chromium:916975
Change-Id: I566843b52d33d34fa8686e17ef3752c59041c4bf
Reviewed-on: https://chromium-review.googlesource.com/c/1386435
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618204}
[modify] https://crrev.com/daa412537ed3389d4a5efe82c13ef8f8835c5548/third_party/blink/web_tests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe6a58875e21eb3cd833b9507db2acabfb3f9834

commit fe6a58875e21eb3cd833b9507db2acabfb3f9834
Author: Fredrik Söderquist <fs@opera.com>
Date: Thu Dec 20 15:53:15 2018

Remove duplicate TestExpectations entries

TBR=verwaest@chromium.org,jgruber@chromium.org

Bug:  855009 , 916975
Change-Id: I1bf43a418707c064ca902f888161f91c278d91f0
Reviewed-on: https://chromium-review.googlesource.com/c/1386786
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#618222}
[modify] https://crrev.com/fe6a58875e21eb3cd833b9507db2acabfb3f9834/third_party/blink/web_tests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/09674b9283979680e97c0fcdc1e5635ceaa4d106

commit 09674b9283979680e97c0fcdc1e5635ceaa4d106
Author: Toon Verwaest <verwaest@chromium.org>
Date: Tue Jan 08 08:10:03 2019

WIP: [parser] Fix arrow function name inferring

This is a reland of part of
https://chromium-review.googlesource.com/c/v8/v8/+/1397664.

It drops the explicit fni_.Infer() call after parsing arrow functions. We'll
want to avoid inferring if the arrow function is an argument to a function
call.

It also avoids adding the single argument of "name => " to the inferred name.

Bug: chromium:916975
Change-Id: I96a934408113483d73eba14073fe21e8cfe2ada6
Reviewed-on: https://chromium-review.googlesource.com/c/1397665
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58613}
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/src/parsing/parser-base.h
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/debugger/async-chains-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/debugger/async-stack-created-frame-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/debugger/async-stack-for-promise-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/debugger/async-stack-load-more-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/debugger/break-locations-await-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/debugger/break-locations-var-init-optimized-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/debugger/get-possible-breakpoints-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/debugger/max-async-call-chain-depth-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/debugger/promise-chain-when-limit-hit-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/debugger/script-origin-stack-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/debugger/step-into-break-on-async-call-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/runtime/evaluate-run-microtasks-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/runtime/exception-thrown-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/sessions/runtime-console-api-called-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/inspector/sessions/runtime-evaluate-exception-expected.txt
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/message/mjsunit/fail/assert-promise-result-rejects-with-throw-empty.out
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/message/mjsunit/fail/assert-promise-result-rejects.out
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/message/mjsunit/fail/assert-promise-result-resolves.out
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/message/wasm-function-name-async.out
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/message/wasm-function-name-streaming.out
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/message/wasm-module-and-function-name-async.out
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/message/wasm-module-and-function-name-streaming.out
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/message/wasm-module-name-async.out
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/message/wasm-module-name-streaming.out
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/message/wasm-no-name-async.out
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/message/wasm-no-name-streaming.out
[modify] https://crrev.com/09674b9283979680e97c0fcdc1e5635ceaa4d106/test/mjsunit/es8/async-function-stacktrace.js

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3b15230834b46ced69f2a24634da8beabaeface

commit e3b15230834b46ced69f2a24634da8beabaeface
Author: Maya Lekova <mslekova@chromium.org>
Date: Tue Jan 08 09:48:42 2019

[test] Disable test due to error message change in V8

R=hablich@chromium.org, sky@chromium.org

Bug: chromium:916975
Change-Id: I30d8131f8e385ac9f20d71ea3531d4e6f22f24ef
Reviewed-on: https://chromium-review.googlesource.com/c/1388435
Commit-Queue: Michael Hablich <hablich@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620665}
[modify] https://crrev.com/e3b15230834b46ced69f2a24634da8beabaeface/content/test/browser_test_utils_browsertest.cc

Sign in to add a comment