New issue
Advanced search Search tips

Issue 916966 link

Starred by 1 user
Status: Fixed
Owner:
rkgibson@google.com
Closed: Dec 26
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: ----



Sign in to add a comment

Add clipboard time limit to search accelerator menu

Project Member Reported by rkgibson@google.com, Dec 20 
Currently, when the user long-presses the search toolbar button, if there is copied data, the paste options will show up. This is unlike the omnibox autocomplete suggestions, which won't suggest a copied link if the link is too old. We should unify this behavior across all places that use copied data.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83928864c18362a4b0f84bad9bee4104f4655430

commit 83928864c18362a4b0f84bad9bee4104f4655430
Author: Robbie Gibson <rkgibson@google.com>
Date: Wed Dec 26 15:49:26 2018

[iOS] Add pasteboard timeout to search accelerator

To unify the different ways copied content is handled throughout
the app, this CL extends the pasteboard timeout behavior to the
search accelerator menu. (Now, the search accelerator will ignore
copied text from long ago, bringing it in line with other places
that use copied text, like the omnibox autocomplete.)

Bug:  916966 
Change-Id: I2ef3bfc69c0d928c63ee80737aa87209678f6f64
Reviewed-on: https://chromium-review.googlesource.com/c/1390009
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#618931}
[modify] https://crrev.com/83928864c18362a4b0f84bad9bee4104f4655430/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/83928864c18362a4b0f84bad9bee4104f4655430/ios/chrome/browser/ui/popup_menu/popup_menu_action_handler.mm
[modify] https://crrev.com/83928864c18362a4b0f84bad9bee4104f4655430/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm

Comment 2 by rkgibson@google.com, Dec 26

Status: Fixed (was: Started)
►

Sign in to add a comment