New issue
Advanced search Search tips

Issue 916963 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: [Settings] Text in tab strip is loaded twice after killing page

Project Member Reported by dipt...@virtusa.com, Dec 20

Issue description

Chrome Version: 73.0.3646.0 Revision fe8cc77bcda70360146d09741601e582ce676de0-refs/branch-heads/3646@{#1}(32/64 bit)
OS: Windows (7, 8, 8.1, 10), Mac (10.13.1, 10.13.6, 10.14.3) and Linux (14.04 LTS)  

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://settings page then navigate to chrome://settings/manageProfile page
(2) Now type chrome://kill into omnibox to kill the page, then reload page
(3) Click on back and forward navigation button, observe in tab strip.

Actual: Text in tab strip is loaded twice after killing page.

Expected: Text in tab strip should load only at once.

This is a regression issue, broken in 'M73', below is bisect info:

Good Build:73.0.3645.0
Bad Build: 73.0.3646.0

Chromium Bisect:

https://chromium.googlesource.com/chromium/src/+log/d2946b61511979796d459d961e687dc67b15d4c0..bbe151d2e673732cef4f8e5196458b962ed58bd9

Suspect: https://chromium.googlesource.com/chromium/src/+/fd431ba26f7ab34bd0f283e48dca52334affd9f3

@aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank you.


 
Actual_Reload.mp4
745 KB View Download
Expected_Relaod.mp4
485 KB View Download
Cc: johntlee@chromium.org
Cc: -johntlee@chromium.org aee@chromium.org
Labels: -Pri-1 Pri-2
Owner: johntlee@chromium.org
It seems more likely that this was the case since https://chromium-review.googlesource.com/c/chromium/src/+/1381512, than aee,s CL affecting this.

@johntlee: Can you take a look?
Status: WontFix (was: Assigned)
You can also reproduce this by following these steps:

1) Go to chrome://settings
2) Directly from the address bar, go to chrome://settings/changePicture.
3) Hit the back/forward buttons in the browser.

--

What seems to be happening is is that the browser first displays the last known title of the page (the one that's displayed in the history, "Settings - Change picture"). Then, before any JS is run, it changes the title to the text in the <title> tag (which is "Settings"). Then, the JS runs and changes the title back. You can reproduce this bug on any single-page application website, like Drive or YouTube.

I don't think if it's worth fixing. The fix seems like it would require the back-end to be aware of the title before it renders the HTML.

Sign in to add a comment