Issue metadata
Sign in to add a comment
|
Regression: Blue focus ring on 'Google Dashboard' is seen chopped from bottom. |
||||||||||||||||||||||
Issue descriptionChrome Version: 73.0.3646.0 (Official Build) Revision fe8cc77bcda70360146d09741601e582ce676de0-refs/branch-heads/3646@{#1} (64-bit) OS: Mac(10.13.1, 10.13.6, 10.14.3) Pre-condition: -Sign in to chrome with valid credentials Steps to reproduce: 1. Launch Chrome, navigate to 'chrome://settings/appearance' and change font size to 'Very Small'. 2. Go to 'chrome://settings/people' and click on Turn off button to open the 'Turn off sync overlay'. 3. Press tab to bring focus to 'Google Dashboard' and observe. Actual Result : Blue focus ring on 'Google Dashboard' is seen chopped from bottom. Expected Result: Blue focus ring on 'Google Dashboard' should not be seen chopped from bottom. This is a regression issue, broken in 'M-69' and below is the bisect info: Good Build: 69.0.3447.0(Revision: 563479) Bad Build : 69.0.3448.0(Revision: 563958) Change-Log URL: https://chromium.googlesource.com/chromium/src/+log/69.0.3447.0..69.0.3448.0?pretty=fuller&n=10000 Suspecting: r563541 ? @Esmael: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1.Unable to provide 'per-revision' bisect as it shows "Error running the gsutil command: AccessDeniedException: 403" error message,Tried on other machines but still getting the same error again. 2.Unable to perform 'chromium bisect' script as unable to sign-in on chromium builds, hence providing suspect through Manual change-log. 3.Issue is not reproducible on Win(7,8,8.1,10) and Linux(14.04 LTS) 4.This issue is also reproducible on Beta #72.0.3626.28, Dev #73.0.3642.0 & Canary # 73.0.3645.0 Kindly refer the attached screen-cast. Thank You..!
,
Dec 20
,
Dec 21
namratakannan@: I created a CL which adds 2px bottom padding for all dialogs to accommodate the focus outline. Is that okay, or should I limit the padding to the two dialogs known to have the link focus outline chopped at the bottom?
,
Dec 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e3be4ab657ddd91505753ab67801efcf8541367 commit 6e3be4ab657ddd91505753ab67801efcf8541367 Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed Dec 26 20:55:44 2018 WebUI: for the settings-signout-dialog, add padding to dialog body This is needed for when the font size is small on Mac. When the link has focus, the outline is cutoff without the extra padding. Bug: 916939 Change-Id: Idf4101572a125bd2fcfa57a307821f9a17554bfd Reviewed-on: https://chromium-review.googlesource.com/c/1387907 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#618961} [modify] https://crrev.com/6e3be4ab657ddd91505753ab67801efcf8541367/chrome/browser/resources/settings/people_page/signout_dialog.html
,
Dec 26
,
Dec 27
Update: Retested the above issue on Mac(10.13.1, 10.13.6, 10.14.2) using latest Canary Build #73.0.3656.0 and issue is fixed. Kindly refer the below attached screen cast. Thank You! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dpa...@chromium.org
, Dec 20