Update:
Change-Log URL:
https://chromium.googlesource.com/chromium/src/+log/70.0.3503.0..70.0.3504.0?pretty=fuller&n=10000


Suspect: r578334 ?

@Elly Fong-Jones : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 
1. Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect" error message for above range. (tried on other machines but still getting the same error again)
2. Hence providing suspect manually.


Thank You!

 

The download cancellation dialog is very broken.

1. As in comment 0: click the tab's (X) button and the tab disappears before the dialogs appears.
2. Click the window's (X) button and a debug version of Chrome DCHECKs and crashes.

This disappearing tab issue is not Mac-only. This happens on Windows Chrome 71.0.3578.98.

I might split the DCHECK on the window close off into a different bug.

The DCHECK is split into  bug 918683 .

This bug is listed as "started", but we've been asked to take a look at it.
Is it currently being worked?

Pausing work on this until Avi gives me the go-ahead; evidently there's parallel work around this problem (comments on  issue #918683 ) and I don't want to run into a bunch of merge conflicts.

My work will be deleting one of the unload controllers. Please investigate; any changes you make will likely just have to be copy/pasted from UnloadController to FastUnloadController.

If it turns out to be more work on your part than just a copy paste then give me a holler and I'll accelerate the deletion of FastUnloadController.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24a8e7be2b87b713f711bf40a8aa5a023c9a91f0

commit 24a8e7be2b87b713f711bf40a8aa5a023c9a91f0
Author: Dana Fried <dfried@chromium.org>
Date: Wed Jan 09 18:17:27 2019

Warn user when closing last tab during download, not after close.

Creates a more general system to prompt the user when something *might*
end up closing the browser. When MaybeWarnBeforeClosing() is called,
all of the prompts are shown, and if any dialogs do result a callback
happens when they're done. Both the existing on-close logic as well as
the "we might be closing the last tab" logic use this path now.

Bug:  916929 , 918683 
Change-Id: I709bc7205ddb840023c9ca3f696ebceae9a5cee6
Reviewed-on: https://chromium-review.googlesource.com/c/1400051
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621224}
[modify] https://crrev.com/24a8e7be2b87b713f711bf40a8aa5a023c9a91f0/chrome/browser/ui/browser.cc
[modify] https://crrev.com/24a8e7be2b87b713f711bf40a8aa5a023c9a91f0/chrome/browser/ui/browser.h
[modify] https://crrev.com/24a8e7be2b87b713f711bf40a8aa5a023c9a91f0/chrome/browser/ui/unload_controller.cc
[modify] https://crrev.com/24a8e7be2b87b713f711bf40a8aa5a023c9a91f0/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/24a8e7be2b87b713f711bf40a8aa5a023c9a91f0/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/24a8e7be2b87b713f711bf40a8aa5a023c9a91f0/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/24a8e7be2b87b713f711bf40a8aa5a023c9a91f0/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/24a8e7be2b87b713f711bf40a8aa5a023c9a91f0/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/24a8e7be2b87b713f711bf40a8aa5a023c9a91f0/chrome/browser/ui/views/tabs/tab_strip_controller.h

Update:
Retested above issue on  OS : Mac(10.13.6, 10.13.1, 10.14.3) Windows (7,8,8.1,10) using latest Canary #73.0.3667.0 issue is fixed.
Now, Tab strip of incognito window does not disappear for incomplete downloads.

Kindly review the attached screen-cast.
Thank you!

Deleted: Canary#73.0.3667.0.mov 10.6 MB

	Canary#73.0.3667.0.mov 10.6 MB View Download