virtual/.../global-interface-listing-platform-specific.html in webkit_layout_tests failing on chromium.win/WebKit Win10 |
||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of tasak@google.com virtual/.../global-interface-listing-platform-specific.html in webkit_layout_tests failing on chromium.win/WebKit Win10 Builders failed on: - WebKit Win10: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Win10
,
Dec 20
FYI:
[INTERFACES]
interface Bluetooth : EventTarget
attribute @@toStringTag
- getter onadvertisementreceived
method constructor
method requestDevice
- method requestLEScan
- setter onadvertisementreceived
interface BluetoothCharacteristicProperties
attribute @@toStringTag
getter authenticatedSignedWrites
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30e04805f1a169224a4b61ec09c5bad91dc4907a commit 30e04805f1a169224a4b61ec09c5bad91dc4907a Author: Takashi Sakamoto <tasak@google.com> Date: Thu Dec 20 06:20:35 2018 [Sheriff] Mark virtual/stable/webexposed/global-interface-listing-platform-specific.html as failure on WebKit Win10 TBR=ljusten@chromium.org Bug: 916899 Change-Id: I21d9d1c3de9a5ec972c98bcea0ee54526f5dd713 Reviewed-on: https://chromium-review.googlesource.com/c/1386064 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#618125} [modify] https://crrev.com/30e04805f1a169224a4b61ec09c5bad91dc4907a/third_party/blink/web_tests/TestExpectations
,
Dec 20
,
Dec 20
[Sheriff] Removing label Sheriff-Chromium as bug is assigned.
,
Dec 20
In building a web facing feature, Web Bluetooth Scanning, I added a number of functions to the existing interface navigator.bluetooth. In IDL, these functions were marked as runtime enabled:
[RuntimeEnabled=WebBluetoothScanning]
In blink, I have enabled this feature as |test|:
https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/runtime_enabled_features.json5?q=WebBluetoothScanning+-f:out&sq=package:chromium&dr=C&l=1369
I think this means that my newly added functions will show up when content shell tests run, but will not be exposed when we ship.
The confusing part is what to do about the global-interface-listing-platform-specific.html tests. There are at least two test suites that run this test. One requires that the expectations file lists the newly added features. One requires that I don't (the virtual one is run with --stable-release-mode).
Foolip, any ideas?
,
Dec 20
dougt@, do you mean how you should go about updating the expectations? The easiest way ought to be using blink_tool.py rebaseline-cl, documented here: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_test_expectations.md#How-to-rebaseline
,
Dec 20
Sorry if I wasn't clear. webexposed/global-interface-listing-platform-specific.html is called in two test suites. For example: python third_party/blink/tools/run_web_tests.py -t Debug --no-retry-failures --fully-parallel --watch --driver-logging virtual/stable/webexposed/global-interface-listing-platform-specific.html webexposed/global-interface-listing-platform-specific.html The first test is virtual and runs with the --stable-release-mode. The second test runs without this flag. What I think is happening is the first test disables the WebBluetoothScanning runtime flag. This would mean that the expectation file should *not* include any of the Bluetooth Scanning functions. However, the second test has the runtime flag enabled. This would mean that the same expecatations file should include the Bluetooth Scanning functions.
,
Dec 21
Right, there are two variables here: platform-specific baselines and virtual test suites. Here are all the current baselines for this test: third_party/blink/web_tests/platform/linux/virtual/stable/webexposed/global-interface-listing-platform-specific-expected.txt third_party/blink/web_tests/platform/mac/virtual/stable/webexposed/global-interface-listing-platform-specific-expected.txt third_party/blink/web_tests/platform/win7/virtual/stable/webexposed/global-interface-listing-platform-specific-expected.txt third_party/blink/web_tests/webexposed/global-interface-listing-platform-specific-expected.txt There would have been even more if the non-virtual test differed between platforms, and I'm actually surprised it doesn't. But as long as WebBluetoothScanning isn't OS-dependent then the number/name of baseline files should remain the same. Is blink_tool.py rebaseline-cl not able to create the right baselines?
,
Dec 21
+robertma@ in case I am not around when dougt@ tries this next.
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b92b90bd696bfe5cd5210fa0b84d0d2680c59d9 commit 7b92b90bd696bfe5cd5210fa0b84d0d2680c59d9 Author: Doug Turner <dougt@chromium.org> Date: Fri Dec 21 22:40:50 2018 Reenable global-interface-listing-platform-specific.html Running blink_tool.py rebaseline-cl output per instructions. TBR=foolip Bug: 916899 Change-Id: I77b10bcf57a20c511bed0509acbe596ebb1d7526 Reviewed-on: https://chromium-review.googlesource.com/c/1388652 Reviewed-by: Doug Turner <dougt@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#618642} [modify] https://crrev.com/7b92b90bd696bfe5cd5210fa0b84d0d2680c59d9/third_party/blink/web_tests/TestExpectations [add] https://crrev.com/7b92b90bd696bfe5cd5210fa0b84d0d2680c59d9/third_party/blink/web_tests/platform/win/virtual/stable/webexposed/global-interface-listing-platform-specific-expected.txt
,
Dec 28
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tasak@google.com
, Dec 20Owner: dougt@chromium.org