Regression: Shaka-player video black out for a moment and seek bar doesn't appear on mouse hovering. |
|||||||||
Issue descriptionChrome Version: 72.0.3626.28 (Official Build) Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461} (32/64-bit) OS: Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2), Linux(14.04 LTS). URL: http://shaka-player-demo.appspot.com What steps will reproduce the problem? 1. Launch Chrome and navigate to above URL. 2. Select Asset: Anxinom->Clear, Multi-period and hit "Load" button. 3. Click on full-screen icon and wait till seek bar disappears. 4. Now hover the mouse pointer at bottom of screen and observe (refer video). Actual: Video black out for a moment and seek bar doesn't appear on mouse hovering. Expected: Video should not black out and seek bar should appear on mouse hovering. This is a regression issue, broken in M-72 series, below is manual regression range: Good build: 72.0.3611.0 (Revision: 608212) Bad build: 72.0.3612.0 (Revision: 608630) ChangeLog URL: https://chromium.googlesource.com/chromium/src/+log/72.0.3611.0..72.0.3612.0?pretty=fuller&n=10000 Suspecting: https://chromium.googlesource.com/chromium/src/+/e9dca2f22e8863e5f8ec15ca228531f29cec5d5c @kaznacheev: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. Provided Suspect through Change-Log URL because unable to perform Chromium bisect and per-revision bisect both. 2. Chromium builds doesn't supported the MANIFEST.CONTENT, hence unable to play the video in Chromium builds and getting "Shaka Error MANIFEST.CONTENT_UNSUPPORTED_BY_BROWSER ()" error. 2. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting "Error running the gsutil command: AccessDeniedException" error. 3. This issue is also reproducible on Beta #72.0.3626.28, Dev #73.0.3642.0 & Canary # 73.0.3645.0 Kindly review the attached screen-cast for reference. Thank you..!
,
Dec 20
I am pretty sure that the suspected CL (https://chromium-review.googlesource.com/c/chromium/src/+/1336188) cannot be at fault, since it is only adding icons to the Video Player which is a part of ChromeOS Files app, and the above repro steps are all inside a browser page. However, the action that causes the blackout looks related to ChromeOS Shelf. Will investigate.
,
Dec 20
I have run bisect myself and found that the problem is created by this commit: https://chromium-review.googlesource.com/c/chromium/src/+/1337289 It has been reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1338587 And re-reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1340875 Assigning to the owner of the original commit
,
Dec 27
Friendly ping to look into this issue and to provide further update on this issue as it has been marked as a stable blocker. Thanks!
,
Dec 28
The issue is that style changes for a container element which changes its composited layer position, but does not set that the graphics layer subtree needs to be rebuilt. Investigating why now.
,
Dec 29
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71e2c3fd311e47c42854810a9195817981919e3c commit 71e2c3fd311e47c42854810a9195817981919e3c Author: Chris Harrelson <chrishtr@chromium.org> Date: Thu Jan 03 00:26:12 2019 Invalidate the graphics layer subtree on stacking change of descendant PaintLayer. This is because change of stacking may result in a change of the size or position of a composited layer. Bug: 916896 Change-Id: I44d42efc84df892c9e6cbf04f9dcb9ee34a803d9 Reviewed-on: https://chromium-review.googlesource.com/c/1392363 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619544} [modify] https://crrev.com/71e2c3fd311e47c42854810a9195817981919e3c/third_party/blink/renderer/core/paint/paint_layer_stacking_node.cc [add] https://crrev.com/71e2c3fd311e47c42854810a9195817981919e3c/third_party/blink/web_tests/external/wpt/css/CSS2/stacking-context/opacity-change-parent-stacking-context-ref.html [add] https://crrev.com/71e2c3fd311e47c42854810a9195817981919e3c/third_party/blink/web_tests/external/wpt/css/CSS2/stacking-context/opacity-change-parent-stacking-context.html
,
Jan 3
,
Jan 3
Verified in Canary / Mac 73.0.3660.0 The fix is very simple and safe.
,
Jan 4
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 4
branch:3626
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9bda9615837f64f8a33cfed1802a8ee63f5655f commit d9bda9615837f64f8a33cfed1802a8ee63f5655f Author: Chris Harrelson <chrishtr@chromium.org> Date: Fri Jan 04 22:53:32 2019 Invalidate the graphics layer subtree on stacking change of descendant PaintLayer. This is because change of stacking may result in a change of the size or position of a composited layer. Bug: 916896 Change-Id: I44d42efc84df892c9e6cbf04f9dcb9ee34a803d9 Reviewed-on: https://chromium-review.googlesource.com/c/1392363 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#619544}(cherry picked from commit 71e2c3fd311e47c42854810a9195817981919e3c) Reviewed-on: https://chromium-review.googlesource.com/c/1396711 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#573} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/d9bda9615837f64f8a33cfed1802a8ee63f5655f/third_party/blink/renderer/core/paint/paint_layer_stacking_node.cc [add] https://crrev.com/d9bda9615837f64f8a33cfed1802a8ee63f5655f/third_party/blink/web_tests/external/wpt/css/CSS2/stacking-context/opacity-change-parent-stacking-context-ref.html [add] https://crrev.com/d9bda9615837f64f8a33cfed1802a8ee63f5655f/third_party/blink/web_tests/external/wpt/css/CSS2/stacking-context/opacity-change-parent-stacking-context.html
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9bda9615837f64f8a33cfed1802a8ee63f5655f Commit: d9bda9615837f64f8a33cfed1802a8ee63f5655f Author: chrishtr@chromium.org Commiter: chrishtr@chromium.org Date: 2019-01-04 22:53:32 +0000 UTC Invalidate the graphics layer subtree on stacking change of descendant PaintLayer. This is because change of stacking may result in a change of the size or position of a composited layer. Bug: 916896 Change-Id: I44d42efc84df892c9e6cbf04f9dcb9ee34a803d9 Reviewed-on: https://chromium-review.googlesource.com/c/1392363 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#619544}(cherry picked from commit 71e2c3fd311e47c42854810a9195817981919e3c) Reviewed-on: https://chromium-review.googlesource.com/c/1396711 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#573} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 4
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by rbasuvula@chromium.org
, Dec 20