Issue metadata
Sign in to add a comment
|
*/SingleClientPasswordsSyncTest.CommitWithCustomPassphrase/* is flaky |
||||||||||||||||||||
Issue descriptionFindit identified the culprit r617948 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2Q4OWJmNzYzYTI4NTY4MTU3YmIzMGVkZTAzZjg4ODhmODNiOGFmNgw Please revert the culprit or disable the test(s) asap. If you are the owner, please fix! If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r617948&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2Q4OWJmNzYzYTI4NTY4MTU3YmIzMGVkZTAzZjg4ODhmODNiOGFmNgw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Dec 20
[Sheriff] Fix is in the CQ, https://chromium-review.googlesource.com/c/chromium/src/+/1386424.
,
Dec 20
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94c345a1ee2dd5e81d777debf57e134ff7ad74bc commit 94c345a1ee2dd5e81d777debf57e134ff7ad74bc Author: Mikel Astiz <mastiz@chromium.org> Date: Thu Dec 20 13:22:00 2018 Fix CHECK failure if datatype stopped while starting The problematic codepath is when a controller subclass calls ReportModelError() to disable the datatype, usually because of a datatype policy reason (e.g. custom passphrase was enabled and the datatype should be disabled). At this point, the datatype must be precisely loading (MODEL_STARTING) for the crash to repro, which is very unlikely but gets surfaced by integration tests. Bug: 916943 , 916883 , 916886 , 916884 , 916881 Change-Id: I5cdfed50bd28aafc1bd7e5bbbe8d851e0e0100e1 Reviewed-on: https://chromium-review.googlesource.com/c/1386424 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#618193} [modify] https://crrev.com/94c345a1ee2dd5e81d777debf57e134ff7ad74bc/components/sync/driver/model_type_controller.cc [modify] https://crrev.com/94c345a1ee2dd5e81d777debf57e134ff7ad74bc/components/sync/driver/model_type_controller.h [modify] https://crrev.com/94c345a1ee2dd5e81d777debf57e134ff7ad74bc/components/sync/driver/model_type_controller_unittest.cc
,
Dec 20
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by mastiz@chromium.org
, Dec 20Status: Started (was: Untriaged)