New issue
Advanced search Search tips

Issue 916877 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 877648



Sign in to add a comment

[πŸ“] Expire old isolates from isolate cache

Project Member Reported by dtu@chromium.org, Dec 20

Issue description

Pinpoint caches the isolate hashes from prebuilts in its Datastore. But isolates in isolate server expire after a few months. So we have to expire Pinpoint's cache as well.

Example failures
https://pinpoint-dot-chromeperf.appspot.com/job/15c46111140000
https://pinpoint-dot-chromeperf.appspot.com/job/12b4f145140000

Symptoms (what it looks like
When trying to run jobs on old commit ranges, we get this error:
SwarmingTaskError: The swarming task failed with state "BOT_DIED".

The Swarming task logs show this message:
404 Client Error: Not Found for url: https://chrome-isolated.appspot.com/_ah/api/isolateservice/v1/retrieve - Unable to retrieve the entry.
 
Description: Show this description
Blockedon: 877648
Blocking: 877648
Blockedon: -877648
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/a71f8360fc7d00151dc92061fe2235aa05d04fa4

commit a71f8360fc7d00151dc92061fe2235aa05d04fa4
Author: Dave Tu <dtu@chromium.org>
Date: Tue Jan 15 01:20:49 2019

[pinpoint] Ignore cached isolate hashes over 8 weeks old.

Old isolate hashes are expired in isolate server.

Bug: chromium:916877
Change-Id: If7fa3b10491772e0b36b0bf496858068d5cbc818
Reviewed-on: https://chromium-review.googlesource.com/c/1406168
Commit-Queue: Dave Tu <dtu@chromium.org>
Reviewed-by: Juan Antonio Navarro PΓ©rez <perezju@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/a71f8360fc7d00151dc92061fe2235aa05d04fa4/dashboard/dashboard/pinpoint/models/isolate.py
[modify] https://crrev.com/a71f8360fc7d00151dc92061fe2235aa05d04fa4/dashboard/dashboard/pinpoint/models/isolate_test.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9d39cb7402e371e19d1485f07270953c266d4cd

commit c9d39cb7402e371e19d1485f07270953c266d4cd
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Jan 16 02:43:37 2019

Roll src/third_party/catapult 96320b515106..78448d90081e (17 commits)

https://chromium.googlesource.com/catapult.git/+log/96320b515106..78448d90081e


git log 96320b515106..78448d90081e --date=short --no-merges --format='%ad %ae %s'
2019-01-15 vollick@chromium.org Plumb the trace buffer size for atrace
2019-01-15 perezju@chromium.org Revert "[py_utils] Add modules_util.RequireVersion"
2019-01-15 taylori@google.com Fix handling of perfetto protobuf on mac
2019-01-15 perezju@chromium.org [dashboard] Remove dead code in start_try_job.py
2019-01-15 perezju@chromium.org Revert "Remove TagMap."
2019-01-15 perezju@chromium.org [Telemetry] Add list_of_scalar_values.mean
2019-01-15 dtu@chromium.org [pinpoint] Add Tags field to try job dialog.
2019-01-15 dtu@chromium.org [pinpoint] Ignore cached isolate hashes over 8 weeks old.
2019-01-14 eroman@chromium.org Fix import of new NetExport generated logs.
2019-01-14 bsheedy@chromium.org Fix gtest conversion multiplier
2019-01-14 eyaich@google.com Adding timeToFirstViewportReady metric
2019-01-14 perezju@chromium.org [py_utils] Add modules_util.RequireVersion
2019-01-14 perezju@chromium.org Remove GetNetworkData methods
2019-01-14 perezju@chromium.org [cli services] Add buildbucket_service
2019-01-14 perezju@chromium.org [Telemetry] Remove TBMv1 metrics.SmoothnessMetric
2019-01-11 benjhayden@chromium.org Remove TagMap.
2019-01-11 benjhayden@chromium.org Truncate serialized floats in HistogramSet JSON.


Created with:
  gclient setdep -r src/third_party/catapult@78448d90081e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:776709,chromium:777865,chromium:918218,chromium:921616,chromium:874940,chromium:916877, chromium:917273 ,chromium:921342,chromium:904879,chromium:776709,chromium:777865,chromium:480512, chromium:919093 , chromium:691581 ,chromium:921000,chromium:918218,chromium:918208
TBR=sullivan@chromium.org

Change-Id: I75c07d8719f5668f9b4a95a9757cf6c25412b547
Reviewed-on: https://chromium-review.googlesource.com/c/1413252
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623062}
[modify] https://crrev.com/c9d39cb7402e371e19d1485f07270953c266d4cd/DEPS

Sign in to add a comment