Issue metadata
Sign in to add a comment
|
chrome/installer/util/l10n_string_util.cc doesn't build in win cross builds |
||||||||||||||||||||
Issue descriptionhttps://logs.chromium.org/logs/chromium/bb/chromium.clang/linux-win_cross-rel/5014/+/recipes/steps/compile/0/stdout FAILED: obj/chrome/installer/util/with_no_strings/l10n_string_util.obj ../../third_party/llvm-build/Release+Asserts/bin/clang-cl /nologo /showIncludes -imsvc../../third_party/depot_tools/win_toolchain/vs_files/3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c/win_sdk/Include/10.0.17134.0/um -imsvc../../third_party/depot_tools/win_toolchain/vs_files/3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c/win_sdk/Include/10.0.17134.0/shared -imsvc../../third_party/depot_tools/win_toolchain/vs_files/3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c/win_sdk/Include/10.0.17134.0/winrt -imsvc../../third_party/depot_tools/win_toolchain/vs_files/3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c/win_sdk/Include/10.0.17134.0/ucrt -imsvc../../third_party/depot_tools/win_toolchain/vs_files/3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c/VC/Tools/MSVC/14.14.26428/include -imsvc../../third_party/depot_tools/win_toolchain/vs_files/3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c/VC/Tools/MSVC/14.14.26428/atlmfc/include -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"349199\" -D_HAS_NODISCARD -D_HAS_EXCEPTIONS=0 -DCOMPONENT_BUILD -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000002 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBP_EXTERN=extern -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=wchar_t -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DPROTOBUF_USE_DLLS -DBORINGSSL_SHARED_LIBRARY -I../.. -Igen -I../../third_party/libwebp/src -I../../third_party/wtl/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -Igen/protoc_out -Igen/third_party/metrics_proto -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../third_party/lzma_sdk /utf-8 /X -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -fcomplete-member-pointers /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- -fmsc-version=1911 /Zc:dllexportInlines- -m64 /Brepro /W4 -Wimplicit-fallthrough -Wthread-safety /WX /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 /wd4200 /wd4201 /wd4204 /wd4221 /wd4245 /wd4267 /wd4305 /wd4389 /wd4702 /wd4701 /wd4703 /wd4661 /wd4706 /wd4715 -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-null-pointer-arithmetic -Wno-nonportable-include-path -Wno-ignored-pragma-optimize /O1 /Ob2 /Oy- /Zc:inline /Gw /Oi /MD -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare /FIbuild/precompile.h -Wno-shorten-64-to-32 -Wno-inconsistent-missing-override /Fpobj/chrome/installer/util/with_no_strings_cc.pch /Yubuild/precompile.h /TP /wd4577 /GR- /c ../../chrome/installer/util/l10n_string_util.cc /Foobj/chrome/installer/util/with_no_strings/l10n_string_util.obj /Fd"obj/chrome/installer/util/with_no_strings_cc.pdb" ../../chrome/installer/util/l10n_string_util.cc(23,10): fatal error: 'base/win/embedded_i18n/language_Selector.h' file not found #include "base/win/embedded_i18n/language_Selector.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Note: including file: ../../chrome/install_static/install_details.h That bot builds chrome/win on linux. I'm guessing the case of the filename is wrong (linux uses a case-sensitive file system) and it just needs to be language_selector.h with a lower-case s. (See https://chromium.googlesource.com/chromium/src/+/HEAD/docs/win_cross.md for more information.)
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fc33b19991bdf79dc9606564460f63555455e40 commit 3fc33b19991bdf79dc9606564460f63555455e40 Author: Tien Mai <tienmai@chromium.org> Date: Thu Dec 20 13:38:15 2018 Fix cross compile error in l10n_string_util.cc Bug: 916866 Change-Id: Ia30833934c2cadecf33126eda3e008319ec380a3 Reviewed-on: https://chromium-review.googlesource.com/c/1385891 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#618197} [modify] https://crrev.com/3fc33b19991bdf79dc9606564460f63555455e40/chrome/installer/util/l10n_string_util.cc
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a60a6d1125d8f3326c50d29f8f342df57acdbf3b commit a60a6d1125d8f3326c50d29f8f342df57acdbf3b Author: Tien Mai <tienmai@chromium.org> Date: Thu Dec 20 16:40:32 2018 Fix cross compile error in credential_provider Bug: 916866 Change-Id: I12f6d235644850fda295189a776357a5cde5e1de Reviewed-on: https://chromium-review.googlesource.com/c/1386964 Commit-Queue: Tien Mai <tienmai@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#618241} [modify] https://crrev.com/a60a6d1125d8f3326c50d29f8f342df57acdbf3b/chrome/credential_provider/gaiacp/gcp_utils.cc
,
Dec 20
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by tienmai@chromium.org
, Dec 20