Localized description for custom intent: "SearchInChrome" not found for locale |
|||||||||
Issue descriptionTestflight warnings.
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ea9e77a4301e64787c26bdf3eca77f71a72b768 commit 3ea9e77a4301e64787c26bdf3eca77f71a72b768 Author: Justin Cohen <justincohen@google.com> Date: Thu Dec 20 13:07:58 2018 [ios] Supress another testflight submission warning. It's unclear where 'INIntentDescription' is displayed, but testflight submissions are showing warnings when it's not localized. In this case, use the same string as 'INIntentParameterCombinationSubtitle'. Bug: 916865 Change-Id: Iaf9d8a2b5d800dcae41df35522dbd90320af4501 Reviewed-on: https://chromium-review.googlesource.com/c/1385886 Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#618189} [modify] https://crrev.com/3ea9e77a4301e64787c26bdf3eca77f71a72b768/ios/chrome/app/resources/chrome_localize_strings_config.plist
,
Dec 20
Verified the string exists in tot build, but I can't verify this will supress the warning until after CP this to M72. This is low risk.
,
Dec 20
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 3
Approved. Please merge before next Tuesday, so we can test this on next week's beta.
,
Jan 3
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 231457a0b2f969cf25d970f037e2204e9010ed17 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/231457a0b2f969cf25d970f037e2204e9010ed17 Commit: 231457a0b2f969cf25d970f037e2204e9010ed17 Author: justincohen@google.com Commiter: justincohen@chromium.org Date: 2019-01-03 18:30:56 +0000 UTC [ios] Supress another testflight submission warning. It's unclear where 'INIntentDescription' is displayed, but testflight submissions are showing warnings when it's not localized. In this case, use the same string as 'INIntentParameterCombinationSubtitle'. Bug: 916865 Change-Id: Iaf9d8a2b5d800dcae41df35522dbd90320af4501 Reviewed-on: https://chromium-review.googlesource.com/c/1385886 Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#618189}(cherry picked from commit 3ea9e77a4301e64787c26bdf3eca77f71a72b768) Reviewed-on: https://chromium-review.googlesource.com/c/1394728 Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#547} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/231457a0b2f969cf25d970f037e2204e9010ed17 commit 231457a0b2f969cf25d970f037e2204e9010ed17 Author: Justin Cohen <justincohen@google.com> Date: Thu Jan 03 18:30:56 2019 [ios] Supress another testflight submission warning. It's unclear where 'INIntentDescription' is displayed, but testflight submissions are showing warnings when it's not localized. In this case, use the same string as 'INIntentParameterCombinationSubtitle'. Bug: 916865 Change-Id: Iaf9d8a2b5d800dcae41df35522dbd90320af4501 Reviewed-on: https://chromium-review.googlesource.com/c/1385886 Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#618189}(cherry picked from commit 3ea9e77a4301e64787c26bdf3eca77f71a72b768) Reviewed-on: https://chromium-review.googlesource.com/c/1394728 Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#547} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/231457a0b2f969cf25d970f037e2204e9010ed17/ios/chrome/app/resources/chrome_localize_strings_config.plist
,
Jan 4
Realized I didn't add merge-approved label to c5.
,
Jan 7
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 7
,
Jan 9
Per kariahda@, all warnings are now gone. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by justincohen@chromium.org
, Dec 20