New issue
Advanced search Search tips

Issue 916860 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.8%-5.2% regression in rendering.mobile/tasks_per_frame_total_all at 616405:616555

Project Member Reported by kouhei@google.com, Dec 20

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=916860

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=31adc708f666736e614f666ee10eb596cae1c624908cfa263684b7a241b1badc


Bot(s) for this bug's original alert(s):

Android Nexus5X WebView Perf
Android Nexus6 WebView Perf

rendering.mobile - Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Cc: wangxianzhu@chromium.org
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/179f788e140000

[PE] Avoid cache conflict when painting LocalFrameView outside of lifecycle by wangxianzhu@chromium.org
https://chromium.googlesource.com/chromium/src/+/81fc6554b2da741da30913dee5008cc83b20091d
tasks_per_frame_total_all: 234.2 → 245.2 (+11.01)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/10349386140000
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a465e8196b0d3b34cdc2e3acb7b8e79a1d0e4591

commit a465e8196b0d3b34cdc2e3acb7b8e79a1d0e4591
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Dec 21 01:47:55 2018

[PE] Fix SVGImage performance regression

This partly revert the change in svg_image.cc in
https://chromium-review.googlesource.com/c/chromium/src/+/1374779.
For pre-CompositeAfterPaint, still update to pre paint instead of
full cycle before calling PaintOutsideOfLifecycle().

Bug:  916860 
Change-Id: Ic05f56ca17afbb2df9973ee4d32f742b1f4796d8
Reviewed-on: https://chromium-review.googlesource.com/c/1387465
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618428}
[modify] https://crrev.com/a465e8196b0d3b34cdc2e3acb7b8e79a1d0e4591/third_party/blink/renderer/core/svg/graphics/svg_image.cc

 Issue 917247  has been merged into this issue.
 Issue 917236  has been merged into this issue.
 Issue 917246  has been merged into this issue.
Status: Fixed (was: Assigned)

Sign in to add a comment