New issue
Advanced search Search tips

Issue 916858 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Add more i18n placeholder examples to the docs

Project Member Reported by noel@chromium.org, Dec 20

Issue description

Fixing bad i18n placeholders problems recently, I noticed the i18n docs could be improved ...

[1] https://sites.google.com/a/chromium.org/dev/developers/design-documents/ui-localization#TOC-How-to-add-a-string

 - has no <ph> examples at all
    - we should add some
 - Android <ph> special snowflake
    - android has special requirements for special characters
    - has different placeholder format

[2] https://sites.google.com/a/chromium.org/dev/developers/tools-we-use-in-chromium/grit/grit-users-guide#Adding_Resources

 - mentions .rc files %s %d <ph> formats by way of examples.
   - developers might ask: what is an .rc file (it's historical) 
 - Chrome .grd and developers use $1 $2 etc these days, Chrome
   Android uses %1$s %2%d, etc
   - /meh, add bold link in this doc pointing back to [1] so
     that they might be read together

 
Labels: bad-i18n-placeholders OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows OS-iOS
Status: Started (was: Untriaged)
I made the changes listed in the OP, over the last few days already.  This bug's purpose it to record those changes.

Status: Fixed (was: Started)
Added a TOC to the grit users guide while I was there, so I could provides a link to it in bugs under label:bad-i18n-placeholders.
Blockedon: 915561
Blockedon: -915561

Sign in to add a comment