Issue metadata
Sign in to add a comment
|
"Choose tryjobs" link doesn't always show. |
||||||||||||||||||||||
Issue descriptionIt seems random whether the "Choose tryjobs" link shows or not. For example, when I navigated to https://chromium-review.googlesource.com/c/chromium/src/+/1354002 just now, it didn't show: https://screenshot.googleplex.com/FmbhvAb2MED.png Then I pressed reload, and now it shows: https://screenshot.googleplex.com/XdHZXAydqun.png
,
Dec 18
,
Dec 18
I don't have permission to move Gerrit issues to the Chromium project, but this bug should move to Chromium to the "Infra>Platform>Buildbucket>Gerrit" component to reach the team that maintains this particular Chromium Gerrit plugin. Viktar or Logan, can you move this issue to Chromium?
,
Dec 19
,
Dec 19
,
Dec 20
this will have to wait for prod unfreeze
,
Jan 3
The NextAction date has arrived: 2019-01-03
,
Jan 3
deployment started. It will take a few days.
,
Jan 7
hans, can you verify the problem was fixed?
,
Jan 7
,
Jan 10
Still not fixed.
,
Jan 10
mstensho, I cannot reproduce so I will need your help. - were you logged in? the button does not appear until _async_ login flow completes. Then, if you are logged in, the button appears - is the behavior flaky? do you sometimes see the button and sometimes don't? - please provide chrome://version and devtools console contents
,
Jan 10
to be clear, the login flow used by gerrit plugins is separate from Gerrit's own login flow, so even if you see your name in the top-right corner of the page, plugins might not yet know that. I could replace the whole plugin UI with "Loading" until that flow completes to make it less confusing. This applies only if the behavior appears to be flaky
,
Jan 10
,
Jan 10
nodir: I'm always logged in. The behavior is somewhat flaky, and right now I can't reproduce it at all (I could earlier today, though). It used to be easily triggered by this: 1. I go to https://chromium-review.googlesource.com/ (already logged in) 2. I click on a CL in progress, or a draft. 3. No "CHOOSE TRYJOBS" button. 4. Reload. 5. The button is there. I don't think Chrome version matters. I'm usually on Chrome Dev (with some additional features enabled), but I'm pretty sure I've experienced it with vanilla Chrome stable as well. But since I'm currently unable to reproduce it, maybe you want to close this one. I can always reopen it if I manage to reproduce it?
,
Jan 10
it is possible that your browser cached old version of the plugin. That would explain why it worked in the morning. hans, can you reproduce? make sure to hard reload the page, please
,
Jan 14
I can't reproduce today, so I suppose the fix worked. Can you please add a link to the fix on this bug for reference?
,
Jan 14
that code was very unreliable in general, so it was rewritten: https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/1356850 https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/1359914 https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/1365115 https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/1365996 https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/1370786 https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/1370551 https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/1389275 https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/1389277 https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/1365995 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mstensho@chromium.org
, Dec 12