New issue
Advanced search Search tips

Issue 916790 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

No suite link in AsyncSkylabHWTest stage

Project Member Reported by xixuan@chromium.org, Dec 19

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/dea41f5f9cb553e742540bfa83c237dbdc6d77ae

commit dea41f5f9cb553e742540bfa83c237dbdc6d77ae
Author: Xixuan Wu <xixuan@google.com>
Date: Fri Dec 21 23:58:45 2018

autotest: Refactor buildbot logging for further call from --create_and_return.

BUG= chromium:916790 
TEST=Staging lab.

Change-Id: Ifad701074b30b8b62846db47690bcc03de21268a
Reviewed-on: https://chromium-review.googlesource.com/1387584
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/dea41f5f9cb553e742540bfa83c237dbdc6d77ae/venv/skylab_suite/suite_tracking.py

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/00686d425740fe4c4fccd2dfd5b3deab35348e79

commit 00686d425740fe4c4fccd2dfd5b3deab35348e79
Author: Xixuan Wu <xixuan@google.com>
Date: Fri Dec 21 23:58:45 2018

autotest: Add create task link in buildbot for AsyncSkylabStage.

BUG= chromium:916790 
TEST=None.

Change-Id: I9b6d7c7237288ed6afc7303bbb70ce660265366e
Reviewed-on: https://chromium-review.googlesource.com/1387766
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/00686d425740fe4c4fccd2dfd5b3deab35348e79/venv/skylab_suite/cmd/run_suite_skylab.py

Cc: ayatane@chromium.org xixuan@chromium.org
 Issue 917900  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a79b5f773b0ccf9fbf06d7f2bd9d4871312c805a

commit a79b5f773b0ccf9fbf06d7f2bd9d4871312c805a
Author: Xixuan Wu <xixuan@google.com>
Date: Wed Dec 26 23:40:48 2018

autotest: Set suite_id for non-wait skylab suite.

For suite created with '--create_and_return', suite_id is not set, which
cause _log_create_task fail due to suite_id is None.

BUG= chromium:916790 
TEST=None

Change-Id: I97c03da7323cfcdfd479a1a094da4decb02fcf1c
Reviewed-on: https://chromium-review.googlesource.com/1390283
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/a79b5f773b0ccf9fbf06d7f2bd9d4871312c805a/venv/skylab_suite/suite_runner.py

Re #5, what could we have done to protect this in the staging lab?
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5dcca50109e5e6c693f31263859b2cb2f5c2d039

commit 5dcca50109e5e6c693f31263859b2cb2f5c2d039
Author: Xixuan Wu <xixuan@google.com>
Date: Tue Jan 08 04:28:45 2019

autotest: Verify if skylab suite is created successfully in test_push.

BUG= chromium:916790 
TEST=Ran locally.

Change-Id: Ide04a958ffa69a710dfb4324d9e02f14a731b0cb
Reviewed-on: https://chromium-review.googlesource.com/1399081
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/5dcca50109e5e6c693f31263859b2cb2f5c2d039/venv/skylab_staging/swarming.py
[modify] https://crrev.com/5dcca50109e5e6c693f31263859b2cb2f5c2d039/venv/skylab_staging/test_push.py

Status: Fixed (was: Started)

Sign in to add a comment