New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 916753 link

Starred by 1 user
Status: Fixed
Owner:
hansberry@chromium.org
Closed: Dec 20
Cc:
█ jlklein@chromium.org
hsuregan@chromium.org
nohle@chromium.org
khorimoto@chromium.org
█ jhawkins@chromium.org
hansberry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

SmartLock.AuthResult.SignIn* metrics are being recorded at unlock

Project Member Reported by hansberry@chromium.org, Dec 19 
Reproduced multiple times on head.

When I unlock the device with Smart Lock, I see the following in chrome://histograms:

SmartLock.AuthResult.SignIn: 1 sample of "Failure"
SmartLock.AuthResult.SignIn.Failure: 1 sample of "User controller sign in failure"
SmartLock.AuthResult.Unlock: 1 sample of "Success"

Investigating.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fae7c4b81c5056701a823d61d49e9c406a4df40d

commit fae7c4b81c5056701a823d61d49e9c406a4df40d
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Thu Dec 20 01:31:18 2018

Smart Lock: Move SignIn failure metric for decrpytion failure.

The SmartLock.AuthResult.SignIn.Failure bucket "User controller
sign in failure" was being recorded in an area of code that could
also be called by the regular unlock context. Moved to a more
appropriate sign-in only context.

Also fix a minor issue in ScreenlockStateHandler incorrectly
reporting an auth failure in the event that the state has become
active (this occurs after an auth attempt succeeds).

Bug:  916753 
Change-Id: If6a2e41dbe43d50ac869c9c16d6204347a224a75
Reviewed-on: https://chromium-review.googlesource.com/c/1385465
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618064}
[modify] https://crrev.com/fae7c4b81c5056701a823d61d49e9c406a4df40d/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.cc
[modify] https://crrev.com/fae7c4b81c5056701a823d61d49e9c406a4df40d/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/fae7c4b81c5056701a823d61d49e9c406a4df40d/chrome/browser/chromeos/login/easy_unlock/easy_unlock_user_login_flow.cc

Comment 2 by khorimoto@chromium.org, Dec 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment