New issue
Advanced search Search tips

Issue 916752 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: Dec 20
Cc:
wuandy@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 915892


Show other hotlists

Hotlists containing this issue:
Autofill-Fixit


Sign in to add a comment

Autofill.FieldPredictionQuality.ByFieldType.* Should Be a SparseHistogram

Project Member Reported by bcwh...@chromium.org, Dec 19 
The Autofill.FieldPredictionQuality.ByFieldType.* histograms have over 5000 buckets which is a lot of memory used for empty ranges and values unlikely to occur.

Please change it from LinearHistogram to SparseHistogram.  You will not have to rename your metric in histograms.xml for this change as "sparse" is completely compatible with "enumeration".

https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_metrics.cc?rcl=11a9a05dbff5010b373489ed176d0992841c53eb&l=381
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a2d3ee4a1c80746d3c38ff69f6526cbb15abdda

commit 7a2d3ee4a1c80746d3c38ff69f6526cbb15abdda
Author: sebsg <sebsg@chromium.org>
Date: Thu Dec 20 16:51:58 2018

[AF] Make Autofill.FieldPredictionQuality.ByFieldType.* SparseHistogram

Also gets rid of the LogUMAHistogramEnumeration function.

Bug:  916752 ,  850520 
Change-Id: Ia314fbb78f401b284c8da56dcf60995b836cf791
Reviewed-on: https://chromium-review.googlesource.com/c/1385123
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618244}
[modify] https://crrev.com/7a2d3ee4a1c80746d3c38ff69f6526cbb15abdda/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/7a2d3ee4a1c80746d3c38ff69f6526cbb15abdda/components/autofill/core/browser/autofill_metrics.h

Comment 2 by se...@chromium.org, Dec 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment