New issue
Advanced search Search tips

Issue 916749 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

HistoryMenuBridgeTest unit test failures on Mac64 _Beta official.desktop.continuous

Project Member Reported by pbomm...@chromium.org, Dec 19

Issue description

Link to builder :
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20beta/builds/6831

Link to Error :
https://logs.chromium.org/logs/chrome/bb/official.desktop.continuous/mac64_beta/6831/+/recipes/steps/unit_tests/0/logs/HistoryMenuBridgeTest.GotFaviconData/0

Error :
Switch to lite mode | Account Icon pbommana@chromium.org | Logout
0.00s since last line 2018-12-19 9:38:28 AM (PST) 2018-12-19 9:38:28 AM (MTV) 2018-12-19 5:38:28 PM (UTC)
 HistoryMenuBridgeTest.GotFaviconData (run #1):
 [ RUN      ] HistoryMenuBridgeTest.GotFaviconData
 Received signal 11 SEGV_MAPERR 000000000000
  [0x00010d54a64f]
  [0x00010d54a561]
  [0x7fffa6ecfbba]
  [0x7fff8f62fc5b]
  [0x00010d504ba6]
  [0x00010d4dae65]
  [0x00010a626a8d]
  [0x00010a626a17]
  [0x00010a94ac3f]
  [0x00010a94b1c7]
  [0x00010a957557]
  [0x00010a9571dd]
  [0x00010cc44c86]
  [0x00010cc52e7a]
  [0x00010cc52d2a]
  [0x00010cc38c0a]
  [0x7fffa6cc2255]
  [0x000000000006]
 [end of stack trace]
 
Cc: pucchakayala@chromium.org
Just to update:

Same issue still seen on mac 64 beta of continuous builder.

Link to the builder:
-------------------
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20beta/builds/6872

link to error log:
-----------------
https://logs.chromium.org/logs/chrome/bb/official.desktop.continuous/mac64_beta/6872/+/recipes/steps/unit_tests/0/stdout

Could some one from dev team please take a look.
Thanks..!
Cc: pnangunoori@chromium.org
Labels: Target-73 M-73 FoundIn-73
Just to update:

Same issue still seen on Mac64 - Canary of Official builder.

Link to the builder:
-------------------
https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/3778

link to error log:
-----------------
https://logs.chromium.org/logs/chrome/bb/official.desktop/mac64/3778/+/recipes/steps/unit_tests/0/stdout

Thanks!
Labels: -Pri-1 -M-72 -Target-72 Pri-2
Owner: a...@chromium.org
Status: Assigned (was: Untriaged)
Mac triage: to avi@ - can you take a peek at this failure?
I genuinely am not understanding HistoryMenuBridgeTest.GetFaviconForHistoryItem and HistoryMenuBridgeTest.GotFaviconData. They both call HistoryMenuBridge::GetFaviconForHistoryItem which *starts a background task*. They then test some things and then *end*, racing the task, which may or may not finish before the HistoryMenuBridge that's instantiated for the test is torn down!
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/019667bdfb7f4c9c89bd7e9fce80c0193633f141

commit 019667bdfb7f4c9c89bd7e9fce80c0193633f141
Author: Avi Drissman <avi@chromium.org>
Date: Wed Jan 02 19:57:36 2019

Avoid races in HistoryMenuBridge.

BUG= 916749 

Change-Id: Ideb4f53009923138676063e2186332c0b4d147a2
Reviewed-on: https://chromium-review.googlesource.com/c/1393021
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619460}
[modify] https://crrev.com/019667bdfb7f4c9c89bd7e9fce80c0193633f141/chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm

Status: Fixed (was: Assigned)
That should deflake the test.

Sign in to add a comment