New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 916745 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Implement help indicator on chromium-coverage plugin to explain why the text is red

Project Member Reported by liaoyuke@chromium.org, Dec 19

Issue description

sky@'s suggestion.

I think this is a very good suggestion, but I couldn't find a good way/place to show the indicator.

+ajp@, +viktard@, do you know if there is a good entry point for Gerrit plugin to achieve that?

Here is a link to an example of the highlighted text: https://chromium-review.googlesource.com/c/chromium/src/+/1369647/4/base/files/file_util_unittest.cc
 
I do not, I'm not too familiar with Gerrit plugin development. That said, if more work was going to go into this, I'd be curious if a moving to a more standard UI, for example, doing the work to get the indicators in the gutter/line number area would be better and potentially more intuitive / familiar for users.

Sign in to add a comment