New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 916715 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Double tap for child frame widgets won't work

Project Member Reported by danakj@chromium.org, Dec 19

Issue description

Looks like RenderWidgetHostViewAura::RequiresDoubleTapGestureEvents() would return the wrong thing (always false) for any child local root, it only does the right thing when there is an owner delegate on the RenderWidgetHost, which implies the RenderWidget is for the main frame.

bool RenderWidgetHostViewAura::RequiresDoubleTapGestureEvents() const {
  RenderViewHost* rvh = RenderViewHost::From(host());
  return rvh && rvh->GetWebkitPreferences().double_tap_to_zoom_enabled;
}

(From 822455)
 
Description: Show this description
afakhry@ - You mentioned double-tap to zoom has been turned off since M-70. Is there a CL for that?
Status: Assigned (was: Untriaged)
Yes, https://chromium-review.googlesource.com/c/chromium/src/+/1311693

Sign in to add a comment