New issue
Advanced search Search tips

Issue 916690 link

Starred by 2 users
Status: Untriaged
Owner: ----
Cc:
ricea@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebSockets socket pool enforces HTTP socket rules when using SSL

Project Member Reported by mmenke@chromium.org, Dec 19 
There is a separate WebSockets socket pool, which enforces its own connection limits in a completely different way than the normal socket pools.  We then place a normal SSLSocketPool on top of it.  The SSLSocketPool enforces HTTP connection limits, so thus all wss connections seem to be subject to the HTTP connection limits.

Comment 1 by ricea@chromium.org, Jan 7 

It's a bit more complicated than that, because the test WebSocketBrowserTest.SSLConnectionLimit passes. IIRC, we made this work by setting the size of the SSLSocketPool to 256.

Comment 2 by yhirano@chromium.org, Jan 15

Status: Available (was: Untriaged)

Comment 3 by mmenke@chromium.org, Jan 15

Owner: mmenke@chromium.org
Status: Assigned (was: Available)
So not really a problem.  Regardless, we should get this non-issue resolved for free with my socket pools refactor.

Comment 4 by mmenke@chromium.org, Jan 18 (4 days ago)

Owner: ----
Status: Untriaged (was: Assigned)
There's a bigger issue here, which I hadn't noticed:  We aren't using WebSocketTransportClientSocketPool when there's a proxy in use, instead we're using a separate group of TransportClientSocketPools, so we use normal TransportClientSocketPool rules (With the modified socket limits, but no WebSockets rate limiting at all) with proxies.

I think fixing that would require more thinking about how to handle websockets backoff with proxies than I'm willing to invest in, so unassigning from myself.
►

Sign in to add a comment