New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 916680 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Xcodebuild test failed because of 'Error Domain=DVTCoreSimulatorAdditionsErrorDomain Code=0 "(null)"'

Project Member Reported by monufriienko@chromium.org, Dec 19

Issue description

Config to run was picked
https://chromium-review.googlesource.com/c/chromium/src/+/1383296/24

Failed build
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/ios12-sdk-simulator/108

Xcode-build restarted command 4 times but every time it failed with

Error Domain=DVTCoreSimulatorAdditionsErrorDomain Code=0 "(null)"
Error Domain=IDETestOperationsObserverErrorDomain Code=4 "Failed to install or launch the test runner" UserInfo={NSLocalizedRecoverySuggestion=If you believe this error represents a bug, please attach the log file at /b/s/w/ioCueUMs/12.1 iPhone X/attempt_0/1_Test/Diagnostics/ios_chrome_ui_egtests_module-6AD0CDB0-5869-49B4-A3FC-2FDF42DC7E18/ios_chrome_ui_egtests_module-1AA0FDEE-2F87-4FB0-ADEC-252C0D652787/Session-ios_chrome_ui_egtests_module-2018-12-19_051106-xbLBly.log, NSLocalizedDescription=Failed to install or launch the test runner, NSUnderlyingError=0x7fb2278148d0 {Error Domain=DVTCoreSimulatorAdditionsErrorDomain Code=0 "(null)"}}

Diagnostic logs are in 'test_data' folder:
https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=1f01aec6b20ccb2964be8d4915f71af9254bc208
 
Components: -Infra>Client Infra>Client>Chrome
Labels: -OS-Mac
Status: Assigned (was: Untriaged)
FYI, there is a http://go/ios-ops-ticket template for bugs like this.

FWIW, I don't see the usual Xcode installation line in the task logs - it should look something like:

  About to install Xcode 10b61 in Xcode.app for ios

Does the new test_runner code install Xcode on the bot?
Oh, thank you for the template for the ios-ops feature.
Runner doesn't do installation
I've just checked the log, it seems that builder automatically tried to install XCode 10 (please see screenshot)
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/ios12-sdk-simulator/108

or it should be done directly in the runner?
Screen Shot 2018-12-19 at 1.04.32 PM.png
59.9 KB View Download
Owner: monufriienko@chromium.org
The test runner also needs to install Xcode, since it runs on a different machine. The other types of tests do it through the base class: https://cs.chromium.org/chromium/src/ios/build/bots/scripts/test_runner.py?l=338&rcl=ba0a32e3d766193405acc50b8a21fe76ad22efa1

The bug appears to be here: https://cs.chromium.org/chromium/src/ios/build/bots/scripts/xcodebuild_runner.py?l=452&rcl=09c3ee6bd4e8945e60ef363e811d7b01bb2e5e58
The constructor needs to call the base class's __init__() which would then install the Xcode and other necessary bits.

Reassigning the bug to you, since this sounds like a problem with the test runner code.
Updated __init__ method and now tests are passing!
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/ios-simulator/162075
Thank you, Sergey!
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6b9bbabb2780b830868731d04efab1f6e8ee791

commit a6b9bbabb2780b830868731d04efab1f6e8ee791
Author: git config --global <monufriienko@chromium.org>
Date: Thu Dec 20 19:55:50 2018

Updated SimulatorParallelTestRunner.__init__

Need to call super.__init__ to make sure that proper XCode is installed
and pre-conditions(wipe, kill) for simulators are done.

Bug:  916680 
Change-Id: I50a00c8ee7f0ac692553d98cbc40b0c331cc652b
Reviewed-on: https://chromium-review.googlesource.com/c/1385066
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618295}
[modify] https://crrev.com/a6b9bbabb2780b830868731d04efab1f6e8ee791/ios/build/bots/scripts/run.py
[modify] https://crrev.com/a6b9bbabb2780b830868731d04efab1f6e8ee791/ios/build/bots/scripts/xcodebuild_runner.py

Status: Fixed (was: Assigned)

Sign in to add a comment