New issue
Advanced search Search tips

Issue 916656 link

Starred by 2 users
Status: Fixed
Owner:
dougt@chromium.org
Closed: Jan 4
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Bluetooth::requestLEScan() and requestDevice

Project Member Reported by dougt@chromium.org, Dec 19 
From code review in https://chromium-review.googlesource.com/c/chromium/src/+/1366318/24/third_party/blink/renderer/modules/bluetooth/bluetooth.cc#276

we can probably Check GetFrame() == nullptr early and bail out.  This will reduce the # of checks on frame and simplify the code a bit.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05ab1c1c2d47097a815d665ae24b50817b573ec5

commit 05ab1c1c2d47097a815d665ae24b50817b573ec5
Author: Doug Turner <dougt@chromium.org>
Date: Fri Jan 04 02:40:53 2019

WebBluetooth - Bail early if there is a null frame.

If we find a null frame, we reject with a "Document not active"
exception.

Bug:  916656 
Change-Id: If76de22eb1fd977571bb7517e6d745e3ad9077e9
Reviewed-on: https://chromium-review.googlesource.com/c/1391773
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619867}
[modify] https://crrev.com/05ab1c1c2d47097a815d665ae24b50817b573ec5/third_party/blink/renderer/modules/bluetooth/bluetooth.cc

Comment 2 by dougt@chromium.org, Jan 4

Status: Fixed (was: Assigned)
►

Sign in to add a comment