New issue
Advanced search Search tips

Issue 916654 link

Starred by 1 user
Status: Fixed
Owner:
dougt@chromium.org
Closed: Dec 29
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Bluetooth::requestLEScan() PRE_FINALIZER clean up

Project Member Reported by dougt@chromium.org, Dec 19 
Per code review, we should assert that ContextDestroyed() will always be called before this object becomes garbage and so assert that the pre-finalizer is not required.

Additionally, we might be able to get rid of the PRE_FINALIZER if we can prove to ourselves that ContextDestroyed() is always called before ~().
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3985212b374e3ca18d0628b9f660e119bf80d6a0

commit 3985212b374e3ca18d0628b9f660e119bf80d6a0
Author: Doug Turner <dougt@chromium.org>
Date: Fri Dec 28 21:20:00 2018

WebBluetooth - Assert that ContextDestroyed() will always be called.

Bug:  916654 
Change-Id: Ic5d7fb6b8921bef9f9c1a76115e944189d1ee812
Reviewed-on: https://chromium-review.googlesource.com/c/1391736
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619194}
[modify] https://crrev.com/3985212b374e3ca18d0628b9f660e119bf80d6a0/third_party/blink/renderer/modules/bluetooth/bluetooth.cc

Comment 2 by dougt@chromium.org, Dec 29

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98eb9a732a30b52b4b95075d2742bc4325ae15b4

commit 98eb9a732a30b52b4b95075d2742bc4325ae15b4
Author: Doug Turner <dougt@chromium.org>
Date: Fri Jan 04 02:45:23 2019

WebBluetooth - Remove unneeded pre-finalizer in renderer bluetooth.cc

Bug:  916654 
Change-Id: I70e2f99d558c797b0d1d98cb543fdc13c866e091
Reviewed-on: https://chromium-review.googlesource.com/c/1394374
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619869}
[modify] https://crrev.com/98eb9a732a30b52b4b95075d2742bc4325ae15b4/third_party/blink/renderer/modules/bluetooth/bluetooth.cc
[modify] https://crrev.com/98eb9a732a30b52b4b95075d2742bc4325ae15b4/third_party/blink/renderer/modules/bluetooth/bluetooth.h
►

Sign in to add a comment