New issue
Advanced search Search tips

Issue 916651 link

Starred by 2 users
Status: Fixed
Owner:
bialpio@chromium.org
Closed: Today
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task



Sign in to add a comment

Use com.google.ar.core.InstallActivity to install ARCore

Project Member Reported by bialpio@google.com, Dec 19 
Start using com.google.ar.core.InstallActivity to install ARCore.

If it turns out that we should not use the InstallActivity, remove it
from the base manifest - .aar dependencies have their manifest files merged into the main one & we need to ensure that manifest entry for this activity is not being added.

Comment 1 by bialpio@google.com, Dec 19

Summary: Understand implications of adding ARCore's InstallActivity to AndroidManifest.xml (was: Understand implications of adding ARCoreInstallActivity to AndroidManifest.xml)

Comment 2 by bialpio@google.com, Dec 19

Description: Show this description

Comment 3 by ddorwin@chromium.org, Dec 19

Labels: -Type-Bug -Pri-3 Target-73 OS-Android Pri-1 Type-Task
Owner: bialpio@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by bialpio@chromium.org, Dec 20

Summary: Use com.google.ar.core.InstallActivity to install ARCore (was: Understand implications of adding ARCore's InstallActivity to AndroidManifest.xml)

Comment 5 by bialpio@chromium.org, Dec 20

Description: Show this description

Comment 6 by bialpio@chromium.org, Jan 15

Blockedon: 921761

Comment 7 by bialpio@chromium.org, Jan 18 (4 days ago)

Blockedon: -921761
Status: Started (was: Assigned)
CL: https://chromium-review.googlesource.com/c/chromium/src/+/1406192
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d0280d6ec272b6f935e877a6fac648ca2a20ef3

commit 1d0280d6ec272b6f935e877a6fac648ca2a20ef3
Author: Piotr Bialecki <bialpio@chromium.org>
Date: Fri Jan 18 21:47:03 2019

Start leveraging ARCore SDK's InstallActivity

More significant changes:
- rename nativeOnRequestInstallSupportedArCoreCanceled into
  nativeOnRequestInstallSupportedArCoreResult and add boolean parameter
  to it in order to propagate result of installation
- modify ArCoreJavaUtils to start using ArCoreApk.requestInstall via
  reflection
- notify ArDelegate when ChromeActivity's onResumeWithNative
  gets called
- ArDelegate will notify ArCoreJavaUtils that the activity is
  being resumed

Bug:  916651 ,  850840 
Change-Id: I0d906f3bee7f19f36e1f532670e079018d4120b0
Reviewed-on: https://chromium-review.googlesource.com/c/1406192
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624303}
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreJavaUtils.java
[add] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreShim.java
[add] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreShimImpl.java
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java/src/org/chromium/chrome/browser/vr/ArDelegate.java
[add] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java/src/org/chromium/chrome/browser/vr/ArDelegateImpl.java
[add] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java/src/org/chromium/chrome/browser/vr/ArDelegateProvider.java
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java_sources.gni
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/modules/ar/ar_module_tmpl.gni
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/browser/android/vr/BUILD.gn
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/browser/android/vr/arcore_device/arcore_device.cc
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/browser/android/vr/arcore_device/arcore_device.h
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/browser/android/vr/arcore_device/arcore_java_utils.cc
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/browser/android/vr/arcore_device/arcore_java_utils.h

Comment 9 by bialpio@chromium.org, Today (7 hours ago)

Status: Fixed (was: Started)
►

Sign in to add a comment