View and admin operations will need different acls.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/ec22b50c5475abd2c64e866341fb9df73716155e commit ec22b50c5475abd2c64e866341fb9df73716155e Author: Aviv Keshet <akeshet@chromium.org> Date: Wed Dec 19 19:55:49 2018 qscheduler: separate view operations from admin operations View and Admin operations on a qscheduler instance will eventually have different ACLs. Separate them into two services to make ACLs easier to construct. BUG= 916616 Change-Id: I286b6a07ae7da4acdf710470ddf39456c4271ad0 Reviewed-on: https://chromium-review.googlesource.com/c/1384884 Auto-Submit: Aviv Keshet <akeshet@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> Commit-Queue: Aviv Keshet <akeshet@chromium.org> Cr-Commit-Position: refs/heads/master@{#19676} [modify] https://crrev.com/ec22b50c5475abd2c64e866341fb9df73716155e/go/src/infra/appengine/qscheduler-swarming/app/frontend/frontend.go [modify] https://crrev.com/ec22b50c5475abd2c64e866341fb9df73716155e/go/src/infra/appengine/qscheduler-swarming/app/frontend/qscheduler_admin.go [modify] https://crrev.com/ec22b50c5475abd2c64e866341fb9df73716155e/go/src/infra/appengine/qscheduler-swarming/app/config/config.pb.go [add] https://crrev.com/ec22b50c5475abd2c64e866341fb9df73716155e/go/src/infra/appengine/qscheduler-swarming/api/qscheduler/v1/qschedulerviewserver_dec.go [modify] https://crrev.com/ec22b50c5475abd2c64e866341fb9df73716155e/go/src/infra/appengine/qscheduler-swarming/api/qscheduler/v1/admin.proto [modify] https://crrev.com/ec22b50c5475abd2c64e866341fb9df73716155e/go/src/infra/appengine/qscheduler-swarming/api/qscheduler/v1/qscheduleradminserver_dec.go [modify] https://crrev.com/ec22b50c5475abd2c64e866341fb9df73716155e/go/src/infra/appengine/qscheduler-swarming/api/qscheduler/v1/admin.pb.go [modify] https://crrev.com/ec22b50c5475abd2c64e866341fb9df73716155e/go/src/infra/appengine/qscheduler-swarming/api/qscheduler/v1/gen.go [modify] https://crrev.com/ec22b50c5475abd2c64e866341fb9df73716155e/go/src/infra/appengine/qscheduler-swarming/app/frontend/qscheduler_admin_test.go [modify] https://crrev.com/ec22b50c5475abd2c64e866341fb9df73716155e/go/src/infra/appengine/qscheduler-swarming/api/qscheduler/v1/pb.discovery.go
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/001340d11157fd6a5e2a7fd82bd86c9af5d313cd commit 001340d11157fd6a5e2a7fd82bd86c9af5d313cd Author: Aviv Keshet <akeshet@chromium.org> Date: Wed Dec 19 22:32:11 2018 qscheduler: add a view group and grant it (and admin) view access Also, remove duplicated code for access checking. BUG= 916616 Change-Id: I70afbf8f3e0e9be193c395c5bfb51426447efdf5 Reviewed-on: https://chromium-review.googlesource.com/c/1384885 Reviewed-by: Xixuan Wu <xixuan@chromium.org> Commit-Queue: Aviv Keshet <akeshet@chromium.org> Cr-Commit-Position: refs/heads/master@{#19681} [modify] https://crrev.com/001340d11157fd6a5e2a7fd82bd86c9af5d313cd/go/src/infra/appengine/qscheduler-swarming/app/config/config.pb.go [modify] https://crrev.com/001340d11157fd6a5e2a7fd82bd86c9af5d313cd/go/src/infra/appengine/qscheduler-swarming/app/config/config.proto [modify] https://crrev.com/001340d11157fd6a5e2a7fd82bd86c9af5d313cd/go/src/infra/appengine/qscheduler-swarming/app/frontend/frontend.go
Comment 1 by bugdroid1@chromium.org
, Dec 19