New issue
Advanced search Search tips

Issue 916588 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Feedless failing to generate build files

Project Member Reported by s...@chromium.org, Dec 19

Issue description

First failing build https://uberchromegw.corp.google.com/i/internal.client.clank/builders/monochrome-feedless-builder/builds/3168

If I revert https://chrome-internal.googlesource.com/clank/internal/apps/+/e28e4df196105ab7de966e9fe88a718c1cf4d6d2 the step succeeds.

To repro, modify components/feed/features.gni to set enable_feed_in_chrome = false;

gn args of

target_os = "android"
target_cpu= "arm"
use_goma = true
is_debug = false
is_official_build = true
use_signing_keys = true
is_chrome_branded = true

And then run "gn gen <out_dir>"

skym@skym-linux2:/usr/local/google/code/clankium/src$ gn gen out/Release/
ERROR at //chrome/android/chrome_public_apk_tmpl.gni:83:32: No value named "shared_library_for_unwind_asset" in scope "invoker"
      library_target = invoker.shared_library_for_unwind_asset
                               ^------------------------------
See //chrome/android/chrome_public_apk_tmpl.gni:231:3: whence it was called.
  chrome_public_common_apk_or_module_tmpl(target_name) {
  ^-----------------------------------------------------
See //clank/java/BUILD.gn:372:3: whence it was called.
  target(invoker.parent_template, target_name) {
  ^---------------------------------------------
See //clank/java/BUILD.gn:617:3: whence it was called.
  chrome_apk_or_module_common_tmpl(target_name) {
  ^----------------------------------------------
See //clank/java/BUILD.gn:765:1: whence it was called.
monochrome_apk_or_module_tmpl("trichrome_chrome_google_apk") {
^-------------------------------------------------------------
See //clank/BUILD.gn:14:5: which caused the file to be included.
    "java:chrome_apk",
    ^----------------

 
Cc: estevenson@chromium.org agrieve@chromium.org fgor...@chromium.org
Owner: torne@chromium.org
Status: Assigned (was: Untriaged)
torne@ - any ideas what's going wrong?
I have a ham-handed CL to fix this https://chromium-review.googlesource.com/c/chromium/src/+/1384660

I'm not very familiar with gn file syntax and style. Feel free to disregard my CL and fix it yourself if you think that'd be easier/better/
This isn't anything to do with feedless; it's broken for target_cpu=="arm" && is_official_build. It's trivial to fix, I'll do that ASAP.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/ebc8f349010931bd504d1dd1914d80e8d42a728b

commit ebc8f349010931bd504d1dd1914d80e8d42a728b
Author: Torne (Richard Coles) <torne@google.com>
Date: Wed Dec 19 19:03:36 2018

Status: Fixed (was: Assigned)
Should be fixed now. Please ping me if any bots show GN failures that in any way seem related to the trichrome APKs though - it's difficult to test all possible GN config combinations locally :(
Thanks for the quick fix! Much appreciated.

Sign in to add a comment