New issue
Advanced search Search tips

Issue 916583 link

Starred by 2 users
Status: Assigned
Owner:
masonfreed@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

FilterOperation::MapRectReverse() for a blur filter actually does a forward (outset) map

Project Member Reported by masonfreed@chromium.org, Dec 19 
FilterOperation::MapRectReverse() for a blur filter actually does a forward (outset) map of the rect. This should be fixed. However, with that "fixed", these layout tests (among others?) fail:

* compositing/culling/filter-occlusion-blur-large.html
* css3/filters/backdrop-filter-basic-blur.html
* virtual/stable/compositing/culling/filter-occlusion-blur-large.html

Likely, somewhere, there is a call to MapRectReverse that really wants to be a call to MapRect.

An example of these failures can be seen here:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/258219

Comment 1 by masonfreed@chromium.org, Dec 19 

These failures are also the result of the same change:

cc_unittests:
LayerTreeHostCommonTest.VisibleRectWithClippingAndFilters
ImageBackdropFilter.BackdropFilterRotated_GL
OcclusionTrackerTestTwoBackdropFiltersReduceOcclusionTwiceImplThreadOpaqueLayers.RunTest
OcclusionTrackerTestDontOccludePixelsNeededForBackdropFilterImplThreadOpaquePaints.RunTest
LayerTreeHostFiltersPixelTest.BackdropFilterBlurOutsets
LayerTreeHostFiltersPixelTest.BackdropFilterBlurOffAxis
LayerTreeHostCommonTest.VisibleRectWithScalingClippingAndFilters
ImageBackdropFilter.BackdropFilterRotated_Software
OcclusionTrackerTestTwoBackdropFiltersReduceOcclusionTwiceImplThreadOpaquePaints.RunTest
OcclusionTrackerTestReduceOcclusionWhenBkgdFilterIsPartiallyOccludedImplThreadOpaqueLayers.RunTest
FilterOperationsTest.MapRectReverseBlur
OcclusionTrackerTestDontOccludePixelsNeededForBackdropFilterImplThreadOpaqueLayers.RunTest
OcclusionTrackerTestReduceOcclusionWhenBkgdFilterIsPartiallyOccludedImplThreadOpaquePaints.RunTest
►

Sign in to add a comment