New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 916576 link

Starred by 2 users
Status: Unconfirmed
Owner: ----
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Findit] Flake Detection - Wrong result: UnsafeSharedMemoryRegionTest.ConvertToSharedMemoryHandle

Project Member Reported by ljusten@chromium.org, Dec 19 
The flake that FindIt found was not caused by a committed CL, but a WIP CL that was requesting a dry run. Is this WAI? It seems like FindIt shouldn't do that. 

See  crbug.com/916534 .

Link to flake details: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWwsSBUZsYWtlIlBjaHJvbWl1bUBiYXNlX3VuaXR0ZXN0c0BVbnNhZmVTaGFyZWRNZW1vcnlSZWdpb25UZXN0LkNvbnZlcnRUb1NoYXJlZE1lbW9yeUhhbmRsZQw

Comment 1 by mattcary@chromium.org, Dec 19 

I wonder if the fact that I was doing a dry run that depended on other WIP CLs is the problem. My commit structure was:

  master --> A---> B
             |---> C
             \---> D

A introduced a new method and added a test for it. This test happened to fail on windows.

B, C and D used the new method, and did not add any new tests.

I put on B, C and D onto the dry run. The test from A failed in each of those dry runs.

Maybe because the test failure was from a test that wasn't in the CL that was being dry-run caused FindIt to think that it was a flake? Especially because it failed in several different apparently unrelated CLs?
►

Sign in to add a comment