New issue
Advanced search Search tips

Issue 916550 link

Starred by 2 users
Status: Untriaged
Owner: ----
Cc:
jochen@chromium.org
clemensh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

cpplint.py no longer maintained upstream

Project Member Reported by clemensh@chromium.org, Dec 19 
I just learned that https://github.com/google/styleguide/tree/gh-pages/cpplint is no longer maintained.
I will update the README.md to mention this.

We should figure out how we want to maintain cpplint.py. Is depot_tools the source of truth? Or should we switch to https://github.com/cpplint/cpplint?
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/2cc6e25536698e4f87d516f5242dd9d30d3245ba

commit 2cc6e25536698e4f87d516f5242dd9d30d3245ba
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Dec 20 08:40:19 2018

[cpplint] Fix regexp for class decorators

This also allows digits in class decorators, to also match macros like
V8_EXPORT_PRIVATE.

Note: I uploaded a pull request for the (previous) upstream at
https://github.com/google/styleguide/pull/422, but then was told that
that repository is not maintained any more.

R=jochen@chromium.org

Bug: chromium:916550

Change-Id: I24cd1829b794b296be8e0c2829271c746751ee1c
Reviewed-on: https://chromium-review.googlesource.com/c/1383472
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>

[modify] https://crrev.com/2cc6e25536698e4f87d516f5242dd9d30d3245ba/cpplint.py
[modify] https://crrev.com/2cc6e25536698e4f87d516f5242dd9d30d3245ba/README.md
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19b494d5a48981bffe10230eaf6b0efd928a6300

commit 19b494d5a48981bffe10230eaf6b0efd928a6300
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Dec 20 11:22:30 2018

Roll src/third_party/depot_tools a3eb0bb167a6..2cc6e2553669 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a3eb0bb167a6..2cc6e2553669


git log a3eb0bb167a6..2cc6e2553669 --date=short --no-merges --format='%ad %ae %s'
2018-12-20 clemensh@chromium.org [cpplint] Fix regexp for class decorators


Created with:
  gclient setdep -r src/third_party/depot_tools@2cc6e2553669

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:916550
TBR=agable@chromium.org

Change-Id: Ib337c3778584f95caca2c7227e7470a26938e1ad
Reviewed-on: https://chromium-review.googlesource.com/c/1386125
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#618165}
[modify] https://crrev.com/19b494d5a48981bffe10230eaf6b0efd928a6300/DEPS
►

Sign in to add a comment