New issue
Advanced search Search tips

Issue 916545 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

|WriteablePrefStore::SetValue| should return |base::Value*|

Project Member Reported by vkuzkokov@chromium.org, Dec 19

Issue description

Chrome Version: ToT
OS: All

|WriteablePrefStore::SetValue| should return |base::Value*| to avoid double lookup when we want to keep a pointer into the pref store. Counting that raw pointer value passed to |SetValue| will remain valid is ungrounded.

|PrefValueMap::SetValue| should probably also return |base::Value*| but there it is complicated by the fact that it already returns |bool| (whether the value is different from the previous one) which is used in a few callers to avoid notifying observers when no actual change happened.
 
Status: Assigned (was: Untriaged)

Sign in to add a comment