New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 916544 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 19
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 707362
issue 916762



Sign in to add a comment

Multiple Mac WebGL testers failing with FATAL:thread_restrictions.cc(116)] Check failed: !g_base_sync_primitives_disallowed.Get().Get

Project Member Reported by jmad...@chromium.org, Dec 19

Issue description

Full error:

1589:775:1218/223456.229690:FATAL:thread_restrictions.cc(116)] Check failed: !g_base_sync_primitives_disallowed.Get().Get(). Waiting on a //base sync primitive is not allowed on this thread to prevent jank and deadlock. If waiting on a //base sync primitive is unavoidable, do it within the scope of a ScopedAllowBaseSyncPrimitives. If in a test, use ScopedAllowBaseSyncPrimitivesForTesting.
0   Chromium Framework                  0x000000011917a75f base::debug::StackTrace::StackTrace(unsigned long) + 31
1   Chromium Framework                  0x0000000119076f3f logging::LogMessage::~LogMessage() + 223
2   Chromium Framework                  0x00000001191411f9 base::internal::AssertBaseSyncPrimitivesAllowed() + 121
3   Chromium Framework                  0x00000001191396ed base::internal::ScopedBlockingCallWithBaseSyncPrimitives::ScopedBlockingCallWithBaseSyncPrimitives(base::BlockingType) + 141
4   Chromium Framework                  0x0000000119188790 base::PlatformThread::Join(base::PlatformThreadHandle) + 48
5   Chromium Framework                  0x000000011913d629 base::Thread::Stop() + 137
6   Chromium Framework                  0x00000001190c9ef9 base::StackSamplingProfiler::SamplingThread::GetOrCreateTaskRunnerForAdd() + 297
7   Chromium Framework                  0x00000001190c9cbe base::StackSamplingProfiler::SamplingThread::Add(std::__1::unique_ptr<base::StackSamplingProfiler::SamplingThread::CollectionContext, std::__1::default_delete<base::StackSamplingProfiler::SamplingThread::CollectionContext> >) + 46
8   Chromium Framework                  0x00000001190cb932 base::StackSamplingProfiler::Start() + 626
9   Chromium Framework                  0x00000001191c4b8a ThreadProfiler::StartPeriodicSamplingCollection() + 426
10  Chromium Framework                  0x00000001191c5397 base::internal::Invoker<base::internal::BindState<void (ThreadProfiler::*)(), base::WeakPtr<ThreadProfiler> >, void ()>::RunOnce(base::internal::BindStateBase*) + 183

Suspecting https://crrev.com/c/1283010 "[PlatformThread] Join() is a wait, update assertions as such." by Gabriel Charette. 

Failing builds:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Experimental%20Release%20%28Intel%29/7486
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Release%20%28Intel%29/9276
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%2010.14%20Release%20%28Intel%29/731
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20Pro%20FYI%20Release%20%28AMD%29/3601
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Experimental%20Retina%20Release%20%28AMD%29/8047
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%2010.14%20Release%20%28AMD%29/645

Several more too. We should probably temporarily revert this to unblock the mac_optional_gpu_tests_rel bot and the ANGLE CQ. Unsure what labels to use here.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9455daee9e580364d5cea224318adc161b4b172

commit a9455daee9e580364d5cea224318adc161b4b172
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Dec 19 16:10:56 2018

Revert "[PlatformThread] Join() is a wait, update assertions as such."

This reverts commit 97120bd710f798ee92a93ed48816b07fd6dbed1b.

Reason for revert: Failures on an optional bot :  crbug.com/916544 

Original change's description:
> [PlatformThread] Join() is a wait, update assertions as such.
> 
> This was using ScopedBlockingCall (which was a 1:1 migration from
> AssertIOAllowed()) for legacy reasons.
> 
> CL continued from https://codereview.chromium.org/2790473006/
> 
> Some of these allowances aren't desired but this CL merely highlights
> existing use cases and as such will not block on fixing them.
> 
> TBR=thestig@chromium.org (trivial side-effects chrome/browser/printing/printer_query.cc)
> 
> Bug:  707362 
> Change-Id: I01a9ae13888ab8602369ddf2d12907388bdc908b
> Reviewed-on: https://chromium-review.googlesource.com/c/1283010
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Reviewed-by: Julien Tinnes <jln@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Toni Baržić <tbarzic@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617724}

TBR=tbarzic@chromium.org,msw@chromium.org,gab@chromium.org,jln@chromium.org,thestig@chromium.org,fdoray@chromium.org,asvitkine@chromium.org,caseq@chromium.org,mmenke@chromium.org

Change-Id: I8f9dd61f7b9e2addbb6d78661d1e9ade0d0f9a85
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  707362 ,  916544 
Reviewed-on: https://chromium-review.googlesource.com/c/1384626
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617846}
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/base/threading/platform_thread_posix.cc
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/base/threading/platform_thread_win.cc
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/base/threading/thread_restrictions.h
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/chrome/browser/devtools/device/android_device_manager.cc
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/chrome/browser/metrics/thread_watcher.cc
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/chrome/browser/printing/printer_query.cc
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/chromeos/process_proxy/process_proxy_unittest.cc
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/content/browser/browser_main_loop.cc
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/content/browser/devtools/devtools_http_handler.cc
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/content/browser/sandbox_host_linux.cc
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/net/base/network_config_watcher_mac.cc
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/net/proxy_resolution/multi_threaded_proxy_resolver.cc
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/net/test/embedded_test_server/embedded_test_server.cc
[modify] https://crrev.com/a9455daee9e580364d5cea224318adc161b4b172/net/test/spawned_test_server/local_test_server_win.cc

Blocking: 707362
Status: Fixed (was: Assigned)
Looks like the trybots are starting to clear up. Closing this out. Gab, you can use mac_optional_gpu_tests_rel to confirm your re-land is fixed. Thanks!
Thanks Jamie for catching this!

Cc: jbudorick@chromium.org chanli@chromium.org st...@chromium.org dpranke@chromium.org bradhall@chromium.org
 Issue 916744  has been merged into this issue.
Blocking: 916762

Sign in to add a comment