Manual Fallback: in passwords present the loading indicator for at least half second |
|||||||||
Issue descriptionTo avoid things flickering, the loading indicator should not be on screen for less than half a second.
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64978f20b0da1e4012a570eaf060fd29f832522d commit 64978f20b0da1e4012a570eaf060fd29f832522d Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Thu Jan 10 18:18:35 2019 [iOS][MF] Present the loading indicator for at least half second Bug: 916541 Change-Id: I4d6c161bbd72838e7e42cdc38298b1248652fb0d Reviewed-on: https://chromium-review.googlesource.com/c/1384248 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#621643} [modify] https://crrev.com/64978f20b0da1e4012a570eaf060fd29f832522d/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm
,
Jan 10
[Auto-generated comment by a script] We noticed that this issue is targeted for M-72; it appears the fix may have landed after branch point, meaning a merge might be required. The owner of this bug should confirm if a merge is required here. If so, add Merge-Request-72 label and indicate which commits/CLs are to be merged. Otherwise, remove Merge-TBD label. Thanks.
,
Jan 11
,
Jan 11
This bug requires manual review: Less than 14 days to go before AppStore submit on M72 Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 11
Canary verification please.
,
Jan 14
Verified in latest Canary
,
Jan 15
Why does this need to make M72? Do you have a video of the flickering?
,
Jan 16
(6 days ago)
Previously the loading indicator would be visible for a couple of milliseconds and then load the credentials. Resolving the flicker was important for UX since it felt quite buggy.
,
Jan 16
(6 days ago)
Approved. Please merge asap.
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/191749be85efaeace4843d452825fa1e64dbd069 commit 191749be85efaeace4843d452825fa1e64dbd069 Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Thu Jan 17 11:37:52 2019 [iOS][MF] Present the loading indicator for at least half second Bug: 916541 Change-Id: I4d6c161bbd72838e7e42cdc38298b1248652fb0d Reviewed-on: https://chromium-review.googlesource.com/c/1384248 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#621643}(cherry picked from commit 64978f20b0da1e4012a570eaf060fd29f832522d) Reviewed-on: https://chromium-review.googlesource.com/c/1417550 Reviewed-by: David Jean <djean@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#718} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/191749be85efaeace4843d452825fa1e64dbd069/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/191749be85efaeace4843d452825fa1e64dbd069 Commit: 191749be85efaeace4843d452825fa1e64dbd069 Author: javierrobles@chromium.org Commiter: djean@chromium.org Date: 2019-01-17 11:37:52 +0000 UTC [iOS][MF] Present the loading indicator for at least half second Bug: 916541 Change-Id: I4d6c161bbd72838e7e42cdc38298b1248652fb0d Reviewed-on: https://chromium-review.googlesource.com/c/1384248 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#621643}(cherry picked from commit 64978f20b0da1e4012a570eaf060fd29f832522d) Reviewed-on: https://chromium-review.googlesource.com/c/1417550 Reviewed-by: David Jean <djean@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#718} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Yesterday
(46 hours ago)
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by javierrobles@chromium.org
, Jan 10