New issue
Advanced search Search tips

Issue 916541 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Manual Fallback: in passwords present the loading indicator for at least half second

Project Member Reported by javierrobles@chromium.org, Dec 19

Issue description

To avoid things flickering, the loading indicator should not be on screen for less than half a second.
 
Status: Fixed (was: Started)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64978f20b0da1e4012a570eaf060fd29f832522d

commit 64978f20b0da1e4012a570eaf060fd29f832522d
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Thu Jan 10 18:18:35 2019

[iOS][MF] Present the loading indicator for at least half second

Bug:  916541 
Change-Id: I4d6c161bbd72838e7e42cdc38298b1248652fb0d
Reviewed-on: https://chromium-review.googlesource.com/c/1384248
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621643}
[modify] https://crrev.com/64978f20b0da1e4012a570eaf060fd29f832522d/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-72; it appears the fix may have landed after branch point, meaning a merge might be required. The owner of this bug should confirm if a merge is required here. If so, add Merge-Request-72 label and indicate which commits/CLs are to be merged. Otherwise, remove Merge-TBD label. Thanks.
Labels: -Merge-TBD Merge-Request-72
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 11

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: Less than 14 days to go before AppStore submit on M72
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Canary verification please.
Status: Verified (was: Fixed)
Verified in latest Canary
Why does this need to make M72? Do you have a video of the flickering?

Comment 9 by martijnb@google.com, Jan 16 (6 days ago)

Previously the loading indicator would be visible for a couple of milliseconds and then load the credentials. Resolving the flicker was important for UX since it felt quite buggy. 

Comment 10 by kariahda@chromium.org, Jan 16 (6 days ago)

Labels: -Hotlist-Merge-Review -Merge-Review-72 Merge-Approved-72
Approved. Please merge asap.
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 17 (5 days ago)

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/191749be85efaeace4843d452825fa1e64dbd069

commit 191749be85efaeace4843d452825fa1e64dbd069
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Thu Jan 17 11:37:52 2019

[iOS][MF] Present the loading indicator for at least half second

Bug:  916541 
Change-Id: I4d6c161bbd72838e7e42cdc38298b1248652fb0d
Reviewed-on: https://chromium-review.googlesource.com/c/1384248
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#621643}(cherry picked from commit 64978f20b0da1e4012a570eaf060fd29f832522d)
Reviewed-on: https://chromium-review.googlesource.com/c/1417550
Reviewed-by: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#718}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/191749be85efaeace4843d452825fa1e64dbd069/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm

Project Member

Comment 12 by cr-audit...@appspot.gserviceaccount.com, Jan 17 (5 days ago)

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/191749be85efaeace4843d452825fa1e64dbd069

Commit: 191749be85efaeace4843d452825fa1e64dbd069
Author: javierrobles@chromium.org
Commiter: djean@chromium.org
Date: 2019-01-17 11:37:52 +0000 UTC

[iOS][MF] Present the loading indicator for at least half second

Bug:  916541 
Change-Id: I4d6c161bbd72838e7e42cdc38298b1248652fb0d
Reviewed-on: https://chromium-review.googlesource.com/c/1384248
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#621643}(cherry picked from commit 64978f20b0da1e4012a570eaf060fd29f832522d)
Reviewed-on: https://chromium-review.googlesource.com/c/1417550
Reviewed-by: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#718}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 13 by djean@chromium.org, Yesterday (46 hours ago)

Labels: Merge-Merged

Sign in to add a comment