New issue
Advanced search Search tips

Issue 916534 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 19
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: UnsafeSharedMemoryRegionTest.ConvertToSharedMemoryHandle



Sign in to add a comment

UnsafeSharedMemoryRegionTest.ConvertToSharedMemoryHandle is flaky

Project Member Reported by Findit, Dec 19

Issue description

Cc: ljusten@chromium.org
Owner: mattcary@chromium.org
Status: Assigned (was: Untriaged)
This seems to be from a dry run on a WIP CL (https://chromium-review.googlesource.com/c/chromium/src/+/1382420). Not sure why FindIt would file a bug for that.

Also, I'm failing to find this test :-/

base/memory/shared_memory_region_unittest.cc contains UnsafeSharedMemoryRegionTest, but there's only CreateFromHandleTest, not ConvertToSharedMemoryHandle, and the file hasn't been touched since Nov 13. Code search gives zero results for ConvertToSharedMemoryHandle.

Matt, any idea?
Ahh, a CL in the chain (https://chromium-review.googlesource.com/c/chromium/src/+/1382418) adds the test. Mystery solved.
You solved it! Sorry for the noise, I had no idea that a chain of WIP CL would make noise for you. All I wanted to do was test my CL on windows :)

At any rate, I found what the problem was and the (still WIP) test passes now, sorry for the noise.
Status: Fixed (was: Assigned)
Honestly, no idea why a dry run would cause FindIt noise. Seems like a bug to me. I've filed crbug.com/916576.

Sign in to add a comment