New issue
Advanced search Search tips

Issue 916531 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocked on:
issue 916528
issue 916518

Blocking:
issue 916516



Sign in to add a comment

Extract CustomTabToolbarCoordinator out of CustomTabActivity

Project Member Reported by pshmakov@google.com, Dec 19

Issue description

Extract the code that works with the toolbar out of CustomTabActivity.

See CustomTabToolbarCoordinator.java in https://crrev.com/1371805 for a rough idea how this class may look like.

Make TrustedWebActivityCoordinator and DynamicModuleCoordinator both work with this new class. Currently TWA and Qwark code hide the toolbar in different ways - see if we can unify that.

Ensure the new class is unit-testable, write a few tests. 

This is a part of CustomTabActivity refactoring plan described in
https://docs.google.com/document/d/1E9u-9eSFjLwVnUUIekhurmKk-8vsSDxek7cZiFd6ToY
 
Blocking: 916516
Description: Show this description

Sign in to add a comment