New issue
Advanced search Search tips

Issue 916528 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocked on:
issue 916518

Blocking:
issue 916516
issue 916531



Sign in to add a comment

Extract CustomTabNavigationController out of CustomTabActivity

Project Member Reported by pshmakov@google.com, Dec 19

Issue description

Extract the code responsible for navigating within the custom tab activity (handling back button, close button, open in browser menu item). This class perhaps should also have a navigate() method for navigation to a new url, which will internally use CustomTabActivityTabController (https://crbug.com/1382496).

See CustomTabNavigationController.java in https://crrev.com/1371805 for a rough idea how this class may look like.

Replace usage of CustomTabActivity in DynamicModuleCoordinator with usage of CustomTabNavigationController.

Ensure the new class is unit-testable, write a few tests. 

This is a part of CustomTabActivity refactoring plan described in
https://docs.google.com/document/d/1E9u-9eSFjLwVnUUIekhurmKk-8vsSDxek7cZiFd6ToY


 
Blockedon: 916518
Blocking: 916531
Blocking: 916516
Description: Show this description

Sign in to add a comment